Silence uninit var warnings for Search::Z3950

Bug #1194142 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

* Evergreen rel_2_4 as of 2013-06-24

The debug logger blindly attempts to access list members that might not exist (if, for example, an event code was returned from the attempt to run do_service_search()), thus generating spurious log warnings. Instead, move the debug line to only generate output when we have actually created the list item in question.

We have approximately 800 of these warnings showing up in our logs on one average day of cataloguing.

See http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/z3950_log_warning for the fix (against rel_2_4).

Tags: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Master and 2.4 updated. Thanks, Dan!

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.