Mir

Mir callback types don't follow the correct coding style

Bug #1194031 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Triaged
Low
Unassigned
mir (Ubuntu)
Triaged
Low
Unassigned

Bug Description

Mir callback types don't follow the correct coding style...

include/shared/mir_toolkit/client_types.h:
typedef void (*mir_connected_callback)(MirConnection *connection, void *client_context);
typedef void (*mir_surface_callback)(MirSurface *surface, void *client_context);
typedef void (*mir_event_delegate_callback)(

I think the correct style would be capitalized like all the other types:
MirConnectedCallback
MirSurfaceCallback
MirEventDelegateCallback (although not sure about the need for "Delegate").

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Setting to medium, because we need the client API to be stable. So issues like this need to be resolved soon.

Changed in mir:
importance: Undecided → Medium
kevin gunn (kgunn72)
Changed in mir:
status: New → Triaged
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

I guess the ship has sailed on this one.

Changed in mir:
status: Triaged → Won't Fix
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Not necessarily. We can add typedefs for the "correct" convention, and consider deprecating the old spelling much later.

Changed in mir:
importance: Medium → Low
status: Won't Fix → Triaged
Revision history for this message
Michał Sawicz (saviq) wrote :

Syncing task from Mir.

Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.