Inventory display in "look at" output is bad
Bug #1193494 reported by
Jean-Paul Calderone
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Divmod Imaginary |
Fix Committed
|
Undecided
|
Jean-Paul Calderone | ||
Bug Description
All the items an actor is carrying show up in a list when you look at them:
> look at me
[ Exar ]
Exar is great.
He is wearing a t-shirt and a pair of jeans.
a torch
This is minimally comprehensible. Instead, something like "He is carrying a torch." would be an improvement.
Related branches
lp:~exarkun/divmod.org/explained-inventory-1193494
- Jean-Paul Calderone: Approve
-
Diff: 843 lines (+493/-50)13 files modifiedImaginary/ExampleGame/examplegame/test/test_furniture.py (+4/-7)
Imaginary/ExampleGame/examplegame/test/test_glass.py (+1/-1)
Imaginary/ExampleGame/examplegame/test/test_japanese.py (+4/-3)
Imaginary/ExampleGame/examplegame/test/test_mice.py (+6/-5)
Imaginary/imaginary/language.py (+79/-2)
Imaginary/imaginary/objects.py (+73/-3)
Imaginary/imaginary/test/commandutils.py (+25/-10)
Imaginary/imaginary/test/test_actions.py (+7/-7)
Imaginary/imaginary/test/test_container.py (+170/-6)
Imaginary/imaginary/test/test_garments.py (+4/-3)
Imaginary/imaginary/test/test_illumination.py (+1/-1)
Imaginary/imaginary/test/test_language.py (+116/-0)
Imaginary/imaginary/world.py (+3/-2)
Revision history for this message
| Jean-Paul Calderone (exarkun) wrote | #1 |
| Changed in imaginary: | |
| assignee: | nobody → Jean-Paul Calderone (exarkun) |
| Changed in imaginary: | |
| status: | New → Fix Committed |
To post a comment you must log in.
The "a torch" part of this output comes from an ExpressSurroundings concept. This is created by `Container`, in the implementation of `conceptualize` inherited from `Containment`.
`Container` is shared between locations and actors, so fixing this isn't a simple matter of making `ExpressSurroun