DynamicNotebook tabs are never truly destroyed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Files |
Fix Released
|
High
|
Jeremy Wootten | ||
Granite |
Fix Released
|
Critical
|
Corentin Noël | ||
Midori Web Browser |
Fix Released
|
Critical
|
Corentin Noël |
Bug Description
Revision 6210 caused a regression where granite tabs are not unloaded when closed. To reproduce, play a youtube (html5) video and close the tab to hear it still playing in the background. This does not happen with revision 6209.
ProblemType: Bug
DistroRelease: elementary OS 0.2
Package: midori-granite 0.5.2+r6215-
ProcVersionSign
Uname: Linux 3.8.0-25-generic x86_64
ApportVersion: 2.0.1-0ubuntu17
Architecture: amd64
CrashDB: midori_granite
Date: Wed Jun 19 02:54:21 2013
ExecutablePath: /usr/bin/midori
InstallationMedia: elementary OS 0.2 "Luna" - Beta 2 amd64 (20130506)
MarkForUpload: True
ProcEnviron:
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: midori-granite
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Julián Unrrein (community): Approve
- Cody Garver (community): Needs Fixing
-
Diff: 24 lines (+6/-1)1 file modifiedlib/Widgets/DynamicNotebook.vala (+6/-1)
- Paweł Forysiuk: Approve
- gue5t gue5t: Approve
-
Diff: 59 lines (+9/-5)2 files modifiedmidori/midori-browser.c (+8/-4)
midori/midori-view.c (+1/-1)
- Cody Garver (community): Approve
-
Diff: 29 lines (+8/-3)1 file modifiedlib/Widgets/DynamicNotebook.vala (+8/-3)
Changed in midori: | |
status: | Confirmed → In Progress |
Changed in midori: | |
assignee: | Julián Unrrein (junrrein) → nobody |
status: | In Progress → Confirmed |
Changed in midori: | |
assignee: | nobody → Julián Unrrein (junrrein) |
status: | Confirmed → In Progress |
Changed in granite: | |
milestone: | none → 0.3-beta1 |
importance: | Undecided → Critical |
Changed in granite: | |
milestone: | 0.3-beta1 → luna-rc1 |
Changed in midori: | |
assignee: | Julián Unrrein (junrrein) → nobody |
status: | In Progress → Confirmed |
Changed in granite: | |
status: | New → Confirmed |
Changed in granite: | |
assignee: | nobody → Corentin Noël (tintou) |
status: | Confirmed → Fix Released |
Changed in midori: | |
assignee: | nobody → Corentin Noël (tintou) |
status: | Confirmed → In Progress |
Changed in midori: | |
status: | In Progress → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |
Changed in pantheon-files: | |
status: | In Progress → Fix Committed |
Changed in pantheon-files: | |
milestone: | none → freya-beta2 |
Changed in pantheon-files: | |
status: | Fix Committed → Fix Released |
Changed in pantheon-files: | |
milestone: | freya-beta2 → 0.2 |
Julián, could you please have a look at this? Since you looked at that code before. I'm not sure if the fix was missing something or if it actually uncovered another problem.