OS API servers update() should use result of compute_api.update()

[Chris Behrens]

nova/api/openstack/compute/servers.py:update() has this code:

1003 try:
1004 instance = self.compute_api.get(ctxt, id)
1005 req.cache_db_instance(instance)
1006 self.compute_api.update(ctxt, instance, **update_dict)
1007 except exception.NotFound:
1008 msg = _("Instance could not be found")
1009 raise exc.HTTPNotFound(explanation=msg)
1010
1011 instance.update(update_dict)
1012
1013 self._add_instance_faults(ctxt, [instance])
1014 return self._view_builder.show(req, instance)

line 1011 currently doesn't play well with unified-objects, and is probably not what you really want here. Instead of that, we should probably use the result of the compute_api.update() call on line 1006.

[Alexei Kornienko (alexei-kornienko)]

Fix proposed:
https://review.openstack.org/#/c/33935/

[Alexei Kornienko (alexei-kornienko)]

Was fixed by https://review.openstack.org/#/c/35041/