Launchpad itself

SPPH.buildIndexStanzaFields doesn't include SHA-1/SHA-256 hashes unless in user_defined_fields

Bug #1190879 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
William Grant

Bug Description

SourcePackagePublishingHistory.buildIndexStanzaFields only generates the Files field with MD5 hashes, leaving SHA-1 and SHA-256 up to user_defined_fields. We should probably ignore the package-provided ones and generate our own unconditionally, as apt-ftparchive does now.

Related branches

lp:~wgrant/launchpad/sha256-indices
Steve Kowalik (community): Approve (code)
Diff: 311 lines (+87/-23)
5 files modified
lib/lp/archivepublisher/tests/test_publisher.py (+12/-0)
lib/lp/archiveuploader/dscfile.py (+4/-2)
lib/lp/soyuz/doc/publishing.txt (+6/-0)
lib/lp/soyuz/model/publishing.py (+26/-9)
lib/lp/soyuz/tests/test_publish_archive_indexes.py (+39/-12)
William Grant (wgrant)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16676 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16676>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.