v4-fixed-ip and port-id should not be allowed together when passing networks information in createServer

[Armando Migliaccio]

If I try to boot a server passing both fixed-ip and port-id, the user-specified IP is ignored.

This is obviously in line with the fact that the fixed IP has already been allocated on port creation, but I wonder if nova should validate that and forbid the combination (v4-fixed-ip, port-id) to be submitted in the first place.

This happens on trunk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37989

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37989
Committed: http://github.com/openstack/nova/commit/3ca3fb3ec7a7c6aedb4746969aad91d5fa283408
Submitter: Jenkins
Branch: master

commit 3ca3fb3ec7a7c6aedb4746969aad91d5fa283408
Author: armando-migliaccio <email address hidden>
Date: Fri Jul 19 15:01:21 2013 -0700

    Raise exception if both port and fixed-ip are in requested networks.

    When both fixed-ip and port (uuid) are specified as part of the
    request during server creation, the user specified fixed-ip must
    be ignored because it has already been allocated for the port. For
    compute osapi v3, we raise a BadRequest Exception to ensure the user
    understands why he/she is not getting what he/she asks for.

    This patch also address some minor nits in other error messages.

    Fixed bug #1190777

    Change-Id: Iaf606637a8acf9d20fc6cae0bed5c9a3ea0bf611