Autopilot tests in notes_app.tests.test_quit fail in jenkins ci

Bug #1190630 reported by Francis Ginther
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
notes-app
Fix Released
High
Olivier Tilloy
notes-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The following tests are failing in the jenkins ci tests:

notes_app.tests.test_quit.TestQuit.test_save_before_quit(with mouse)
notes_app.tests.test_quit.TestQuitNoNote.test_save_before_quit(with mouse)

Please see the logs attached to this mp: https://code.launchpad.net/~robru/notes-app/lintian/+merge/168818

Examples:
http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/27
http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/30
http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/33
http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/72

Related branches

Omer Akram (om26er)
Changed in notes-app:
assignee: nobody → Omer Akram (om26er)
importance: Undecided → High
Revision history for this message
Omer Akram (om26er) wrote :

I have made quite a few attempts at fixing these tests. The problem is that it seems alt+f4 is not working in jenkins to close the app due to some reason. So we need to figure out another way to kill the app.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Is this bug still valid?

Revision history for this message
Omer Akram (om26er) wrote :

We are skipping those tests, so that should not affect anything.

Changed in notes-app:
assignee: Omer Akram (om26er) → nobody
Revision history for this message
Olivier Tilloy (osomon) wrote :

Those tests are currently being skipped.
However, looking at the code, there seems to be a way to kill the app that’s already used in the tests. See the launch_and_quit_app() method in tests/autopilot/notes_app/tests/__init__.py, that calls self.doCleanups().
Let’s try and revisit this, to see if we can unskip those tests.

Changed in notes-app:
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in notes-app:
assignee: nobody → Olivier Tilloy (osomon)
status: Confirmed → In Progress
Revision history for this message
Ugo Riboni (uriboni) wrote :

On touch the only way to quit is to go to the shell and quit from the app lens. So a patch has been recently merged that saves the note everytime the app loses focus. Therefore it's not useful to have these tests on touch anymore (especially because we don't receive any signal that we are about to quit on touch systems anyway).

If we still want some form of save-before-quit for the desktop platform, I think that should be addressed separately and with a desktop-only tests.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Yeah that makes sense (and that’s what the linked branch implements).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:notes-app at revision 228, scheduled for release in notes-app, milestone ubuntu-13.04-month-5

Changed in notes-app:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package notes-app - 1.4+14.04.20131204-0ubuntu1

---------------
notes-app (1.4+14.04.20131204-0ubuntu1) trusty; urgency=low

  [ Bill Filler ]
  * Use a different port for the test server when a zombie process
    doesn’t release the default one, and use a cleanup function instead
    of tearDown() for improved robustness.
  * Make sure that clicking outside of the note on the header is
    recognized by enabling the flag that makes the InverseMouseArea the
    topmost item

  [ Olivier Tilloy ]
  * Use the standard UITK emulator for swipe-to-delete gesture and
    confirmation.
  * Unskip some tests on desktop where they work just fine. (LP:
    #1190630)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 232
 -- Ubuntu daily release <email address hidden> Wed, 04 Dec 2013 10:22:47 +0000

Changed in notes-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in notes-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.