Resize a VM when a volume is attached fails

[Emilien Macchi]

Enrivonment : Grizzly, KVM, Cinder NFS Driver (NetAPP)

How to reproduce :

- Create a VM
- Attach a volume
- Resize the VM
- Resize fails

nova-compute.log : http://paste.openstack.org/show/wIGyTWBfjI7IJq8XzBn9/

I should mention that resize is working when a VM has not an attached volume.

[Rafi Khardalian (rkhardalian)]

Confirmed and the impact is slightly broader. It hits the standard NFS driver in addition to the Netapp NFS driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32829
Committed: http://github.com/openstack/nova/commit/e71081b856b06513cc1e56a9adb2a619967f0eae
Submitter: Jenkins
Branch: master

commit e71081b856b06513cc1e56a9adb2a619967f0eae
Author: Rafi Khardalian <email address hidden>
Date: Thu Jun 13 05:09:45 2013 +0000

    Fix resizes with attached file-based volumes

    Bug 1190364

    get_instance_disk_info() now takes an additional, optional argument
    of block_device_info. When passed in, we use it to filter out
    volumes, such that they are not returned. Previously, any devices
    classified as "file" as parsed from the instance XML were considered
    local disks. This assumption is incorrect, since some volumes are
    simply files, rather than block devices.

    Added a new test, based almost entirely off the existing test case
    for this function, which represents an XML file with two fake
    file-based (NFS-like) volumes and associated block_device_info to
    claim those volumes.

    Change-Id: I4809a8fd68eb0f709347aa7cad0fa85389ade41c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/35529

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/35529
Committed: http://github.com/openstack/nova/commit/eff629fa4cfdc68e670d70a4a38810c4935f81af
Submitter: Jenkins
Branch: stable/grizzly

commit eff629fa4cfdc68e670d70a4a38810c4935f81af
Author: Rafi Khardalian <email address hidden>
Date: Thu Jun 13 05:09:45 2013 +0000

    Fix resizes with attached file-based volumes

    Bug 1190364

    get_instance_disk_info() now takes an additional, optional argument
    of block_device_info. When passed in, we use it to filter out
    volumes, such that they are not returned. Previously, any devices
    classified as "file" as parsed from the instance XML were considered
    local disks. This assumption is incorrect, since some volumes are
    simply files, rather than block devices.

    Added a new test, based almost entirely off the existing test case
    for this function, which represents an XML file with two fake
    file-based (NFS-like) volumes and associated block_device_info to
    claim those volumes.

    Change-Id: I4809a8fd68eb0f709347aa7cad0fa85389ade41c
    (cherry picked from commit e71081b856b06513cc1e56a9adb2a619967f0eae)