addFloatingIp with empty IP address should raise a 404 not a 200

[Jordan Pittier]

With Quantum the following request is valid and returns a 202 Accepted : POST http://10.1.59.157:8774/v2/$PROJECT_ID/servers/$server_id/action -d '{"addFloatingIp": {"address": ""}}'

Notice the empty IP Address. Quantum here associates the first free floating IP address in the pool.

But with Nova Network, the exact same request returns a 404 Not Found, as the empty IP address is not found in the pool.

There's a mismatch in the 2 API which causes the Tempest test tempest.api.compute.floating_ips.test_floating_ips_actions:FloatingIPsTestJSON.test_associate_ip_to_server_without_passing_floating_ip to fail.

I am working on a patch for Quantum that will return a 404 if the floating IP address is empty.

Jordan

[Jordan Pittier (jordan-pittier)]

This bug makes the Tempest test tempest.api.compute.floating_ips.test_floating_ips_actions:FloatingIPsTestJSON.test_associate_ip_to_server_without_passing_floating_ip fail

[Justin Hammond (justin-hammond)]

$ curl -i http://172.16.207.227:8774/v2/486ef08727e5408db372bab7bcc3c8ce/servers/c548092c-da73-43ad-bd03-9d06abd81412/action -X POST -H "X-Auth-Project-Id: admin" -H "User-Agent: python-novaclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: <token>" -d '{"addFloatingIp": {"address": ""}}'
HTTP/1.1 404 Not Found
Content-Length: 67
Content-Type: application/json; charset=UTF-8
X-Compute-Request-Id: req-996f9ef4-cc9c-4d96-a05f-bec3b2f45b30
Date: Tue, 10 Sep 2013 20:16:18 GMT

{"itemNotFound": {"message": "floating ip not found", "code": 404}}jhammond at ubuntu in /opt/stack/neutron on master*

I do not appear to have the same issue. Jordan, care to check if this bug is still valid?

[Ionuț Arțăriși (mapleoin)]

Justin, it seems the fix was already committed to master, but was incorrectly tagged:
https://review.openstack.org/#q,Id4843edda8e66ccabab5e9d053c595a1cd247770,n,z
https://github.com/openstack/nova/commit/40126fdb920710e

[Justin Hammond (justin-hammond)]

Thank you mapleoin! Good catch.