php5-fpm does not rotate logs

[Malte S. Stretz]

This isse was reported in bug 706945 in 2011 already but closed as Won't Fix with the weird explanation "php5-fpm has been removed from upstream so im closing this bug." php5-fpm is obviously still in Ubuntu/Debian in 2013 and is still missing a logrotate file.

I noticed this because of a rather big php5-fpm file on a busy staging server.

There is one available in Debian's php5-fpm 5.4.11-1; it would be great if that file could be backported to the package in precise (currently 5.3.10-1ubuntu3.6).

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: php5-fpm 5.3.10-1ubuntu3.6
ProcVersionSignature: Ubuntu 3.2.0-45.70-virtual 3.2.44
Uname: Linux 3.2.0-45-virtual x86_64
ApportVersion: 2.0.1-0ubuntu17.3
Architecture: amd64
Date: Wed Jun 12 09:44:06 2013
InstallationMedia: Ubuntu-Server 12.04.2 LTS "Precise Pangolin" - Release amd64 (20130214)
MarkForUpload: True
ProcEnviron:
 LANGUAGE=en_US:en
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: php5
UpgradeStatus: No upgrade log present (probably fresh install)
modified.conffile..etc.php5.fpm.pool.d.www.conf: [modified]
mtime.conffile..etc.php5.fpm.pool.d.www.conf: 2013-06-11T18:15:23.990370

[Malte S. Stretz (mss)]

Patches:

http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=commitdiff;h=8f8f58989c53b5437d93347a03b0bcf5ef8357f4
http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=commitdiff;h=facf59e6f17fed1249ba0037834a8bd40ae27618

[Robie Basak (racb)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Fixing this in Precise would need to go through the SRU procedure https://wiki.ubuntu.com/StableReleaseUpdates#Procedure and comply with SRU policy (https://wiki.ubuntu.com/StableReleaseUpdates#When).

I'm not sure whether adding a new logrotate file would comply SRU policy or not. Comments appreciated.

If you think that this does meet SRU policy, then please comment with a justification against https://wiki.ubuntu.com/StableReleaseUpdates#When and complete steps 1 through 4 in https://wiki.ubuntu.com/StableReleaseUpdates#Procedure - and go ahead with all the steps if you can. Note that that SRU team would need to make a final decision.

[Robie Basak (racb)]

If this is fixed in Saucy, it should be Fix Released and have a Precise task added. I set this to Confirmed for now so we don't lose it.

[Robie Basak (racb)]

Thinking about it, adding log rotation would just start rotating an already large file. I don't see regression potential except where existing users are already managing the log file in some other way (perhaps as a result of it not having log rotation previously?)

[Malte S. Stretz (mss)]

I'm not sure if it is worth a backport either, just wanted to bring this up. I had to cope with a rather large log file which ate disk space but generally (aka in production) the php5-fpm.log doesn't grow very much and AFAIK is rewound on each restart, too. It would make my life easier though because now I deploy the attached logrotate script manually :)

[Robie Basak (racb)]

OK, then in that case, let's leave it. Marking as Fix Released, as I've verified that /etc/logrotate.d/php5-fpm is provided by php5-fpm in Saucy.