Shotwell tags don't fit in preview, especially with hierarchical tagging

Bug #1190067 reported by Andrew McCarthy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Photos Lens
In Progress
Medium
Andrew McCarthy
unity-lens-photos (Ubuntu)
New
Undecided
Unassigned

Bug Description

Two problems i've found with previews of shotwell photos

1) Tags are listed on one line. Typically (for me) these tags don't fit on one line, and so are truncated.

2) If you use hierarchical tags like A/B/C/D, shotwell stores this as 4 tags, A, A/B, A/B/C and A/B/C/D. The preview tries to list all of these separately, but really you just need to see A/B/C/D.

Related branches

Revision history for this message
Andrew McCarthy (andrewmccarthy) wrote :

I've attached a branch that:

1) changes the list from comma-separated to newline-separated.

2) Merges the hierarchical list so only the longest ones are listed.

The patch from the branch was tested against version 0.9daily12.12.05-0ubuntu1 (in Ubuntu 13.04) but it should work fine as the shotwell scope looks virtually unchanged since.

Revision history for this message
David Callé (davidc3) wrote :

Nice patch. It works well, doesn't conflict with the current design and could certainly be a candidate for a Raring SRU.

To get things started, could you :
1) make a merge proposal on lp:unity-lens-photos, for Saucy
2) make another one on lp:unity-lens-photos/raring

Thanks

David Callé (davidc3)
Changed in unity-lens-photos:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Andrew McCarthy (andrewmccarthy)
Revision history for this message
Andrew McCarthy (andrewmccarthy) wrote :

Just realised my proposal-to-merge for raring would have pulled the entire latest version of the lens. Will make a new branch and to it again. Sorry!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.