OS-DCF:diskConfig="MANUAL" using XML yields Bad Request

[Navneet Kumar]

When creating server via Nova API and specifying OS-DCF:diskConfig="MANUAL" using XML formatted data, the API returns Bad Request.

Steps to Recreate: Create a server with OS-DCF:diskConfig="MANUAL" in an XML Request. This fails with the following error: HTTP/1.1 400 Bad Request

Workaround: Use JSON

[Navneet Kumar (navneetk)]

This bug is due to missing namespace declaration in the xml request body.If we make the request with

<server xmlns="http://docs.openstack.org/compute/api/v1.1" imageRef="1c1796f0-bb4a-4cfc-b0f6-743bd0598b5e" flavorRef="42" os-dcf:diskConfig="MANUAL" name="demo_instance5"/>

it fails with following error: HTTP/1.1 400 Bad Request

But if we make the request with

<server xmlns="http://docs.openstack.org/compute/api/v1.1" xmlns:os-dcf="http://docs.rackspacecloud.com/servers/api/ext/diskConfig/v1.0" imageRef="1c1796f0-bb4a-4cfc-b0f6-743bd0598b5e" flavorRef="42" os-dcf:diskConfig="MANUAL" name="demo_instance5"/>

it gives proper response without any error.

I have attached a screenshot for the same.

[John Garbutt (johngarbutt)]

Is this a bug? Sounds when you give nova a malformed request, it fails, just like you would expect?

What did you use to make the bad request?

[Andrew Laski (alaski)]

I'm also curious what was used to make this request. Does it use the API samples to generate the XML for a request, or something else? Is it just coded to not include the namespace because the sample didn't use it?

If the root of the problem really does come down to the api samples not including a namespace when they should then I feel that the proper fix is to enforce that with the test_api_sample doc generation. Basically instead of fixing this one case manually fix the root cause so that all doc samples are correct.

[Christopher Yeoh (cyeoh-0)]

Agreed, this is a problem with the documentation not specifying that the namespace is required, rather than a problem with the implementation.

[Navneet Kumar (navneetk)]

yes, This is just a problem with generated sample which doesn't clearly specify that namespace is required to use the 'os-dcf:diskConfig' flag.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53589
Committed: http://github.com/openstack/nova/commit/19aee125864204678042d83bc3b4177ccbe0aae9
Submitter: Jenkins
Branch: master

commit 19aee125864204678042d83bc3b4177ccbe0aae9
Author: Chris Yeoh <email address hidden>
Date: Thu Oct 24 21:25:11 2013 +1030

    Adds XML namespace example for disk config extension

    Adds XML namespace and specifying of the disk config value
    to the disk config extensions api sample test data for server
    creation. This is being done so the api samples used by the
    documentation contain the example of this usage.

    DocImpact

    Change-Id: Icd7aa3743f71dd1cb8575605e5f1ce5da6bd37bf
    Closes-Bug: 1189817