User provided headers should not be changed

Bug #1189410 reported by David Hadas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
David Hadas

Bug Description

In order to support Swift extendability
Swift and Swift middleware should avoid changing user provided headers unless required by function.

tempauth changes HTTP_X_AUTH_TOKEN although not required by function (it is done for logging purposes according to the comment just bfore the change), preventing extendability (prevents other middleware to rely on HTTP_X_AUTH_TOKEN representing the token sent by the client).

For example, placement control extension to Swift may require the token to be unchanged to allow active redirecting of calls to remote clusters.

Changed in swift:
assignee: nobody → David Hadas (david-hadas)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/32370

Changed in swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/32370
Committed: http://github.com/openstack/swift/commit/69f58f72a5a3778d7b09c8873c3d1aad4fa51373
Submitter: Jenkins
Branch: master

commit 69f58f72a5a3778d7b09c8873c3d1aad4fa51373
Author: David Hadas <email address hidden>
Date: Mon Jun 10 13:18:42 2013 +0300

    Tempauth - remove change made to HTTP_X_AUTH_TOKEN

    tempauth changes HTTP_X_AUTH_TOKEN although not required by function
    preventing swift extendability.
    (prevents other middleware to rely on HTTP_X_AUTH_TOKEN representing
    the token sent by the client).

    Change-Id: I7ed6f9b5d0a5a203326a3912ef27cf29d2d4e9ce
    Fixes: Bug #1189410

Changed in swift:
status: In Progress → Fix Committed
Changed in swift:
milestone: none → 1.9.0
Thierry Carrez (ttx)
Changed in swift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.