Allow confirm_resize action on an instance in 'deleting' status

Bug #1189391 reported by Aditi Raveesh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Aditi Raveesh
Grizzly
Fix Released
Low
Ruby Loo

Bug Description

Deleting an instance in 'resized' state fails with UnexpectedTaskStateError.
Steps to reproduce:
1. Resize an instance - Instance goes to 'resized' state
2. Delete the instance

The failure occurs because the delete method sets the task_state to 'deleting' and then tries to do a confirm_resize on the instance. Here, the task state check fails. (Expected task state is None, but actually is in 'deleting' state)

Tags: compute
Aditi Raveesh (aditirav)
description: updated
melanie witt (melwitt)
tags: added: compute
Aditi Raveesh (aditirav)
Changed in nova:
assignee: nobody → Aditi Raveesh (aditirav)
Aditi Raveesh (aditirav)
summary: - Handle UnexpectedTaskState and InstanceNotFound exceptions during resize
+ Allow confirm_resize action on an instance in 'deleting' status
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/32689

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/32689
Committed: http://github.com/openstack/nova/commit/0fed513b695cd15aaca24d24926a1c7d13e63509
Submitter: Jenkins
Branch: master

commit 0fed513b695cd15aaca24d24926a1c7d13e63509
Author: Aditi Raveesh <email address hidden>
Date: Wed Jun 12 11:30:47 2013 +0530

    Allow confirm_resize if instance is in 'deleting' status

    Deleting an instance puts it into 'deleting' task_state.
    If the instance is in 'resized' vm_status, this tries a
    confirm_resize on the instance. confirm_resize currently expects
    the task_state to be None. It should instead expect
    None/deleting task_state.

    Fixes bug: 1189391

    Change-Id: I6a3f82eab9ed2242bfd38bc1ac760dbb4b3d8c4a

Changed in nova:
status: In Progress → Fix Committed
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/33825

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/33825
Committed: http://github.com/openstack/nova/commit/f89b19b96bb6dab266c741d39f637dd66eb1c8be
Submitter: Jenkins
Branch: stable/grizzly

commit f89b19b96bb6dab266c741d39f637dd66eb1c8be
Author: Aditi Raveesh <email address hidden>
Date: Wed Jun 12 11:30:47 2013 +0530

    Allow confirm_resize if instance is in 'deleting' status

    Deleting an instance puts it into 'deleting' task_state.
    If the instance is in 'resized' vm_status, this tries a
    confirm_resize on the instance. confirm_resize currently expects
    the task_state to be None. It should instead expect
    None/deleting task_state.

    Fixes bug: 1189391

    Conflicts:
            nova/tests/compute/test_compute.py

    Change-Id: I6a3f82eab9ed2242bfd38bc1ac760dbb4b3d8c4a
    (cherry picked from commit 0fed513b695cd15aaca24d24926a1c7d13e63509)

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Changed in nova:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.