xenapi: agent timeout does not fail the build

[John Garbutt]

Now we no longer check the agent by default, we are really assuming the agent is present on the servers where we check for the agent.

If we don't detect the agent, the server password is no set, and the server networking will not be setup correctly.

Lets look at failing builds if the agent is not present.

Example stack trace:

ERROR nova.virt.xenapi.agent TIMEOUT: The call to version timed out. args={'dom_id': '9190', 'id': 'b8a2ca2f-93d4-40bb-b898-2bad9fa59116', 'timeout': '30', 'host_uuid': 'ef341447-d190-4721-befd-3e0c6a6219ba'}
ERROR nova.virt.xenapi.agent Failed to query agent version: {'message': 'TIMEOUT: No response from agent within 30 seconds.', 'returncode': 'timeout'}
INFO nova.virt.xenapi.agent Reached maximum time attempting to query agent version

DEBUG nova.virt.xenapi.agent Resetting network resetnetwork nova/virt/xenapi/agent.py:281

ERROR nova.virt.xenapi.agent Failed to query agent version: {'message': 'TIMEOUT: No response from agent within 30 seconds.', 'returncode': 'timeout'}
DEBUG nova.virt.xenapi.driver Got exception: ['XENAPI_PLUGIN_FAILURE', 'version', 'PluginError', 'TIMEOUT: No response from agent within 30 seconds.'] _unwrap_plugin_exceptions nova/virt/xenapi/driver.py:756
ERROR nova.virt.xenapi.agent TIMEOUT: The call to version timed out. args={'dom_id': '9194', 'id': '478ca15b-a37b-415d-9d2d-d2abe660f73e', 'timeout': '30', 'host_uuid': 'ef341447-d190-4721-befd-3e0c6a6219ba'}
...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32176

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32176
Committed: http://github.com/openstack/nova/commit/834fc60a8ca852be64aaaaeb5ebb3cc0de807fef
Submitter: Jenkins
Branch: master

commit 834fc60a8ca852be64aaaaeb5ebb3cc0de807fef
Author: John Garbutt <email address hidden>
Date: Fri Jun 7 18:11:09 2013 +0100

    xenapi: revisit error handling around calls to agent

    Now we have settings to hint if the agent is present or not,
    and by default we do not check for the agent,
    if the agent is not responding to our calls for its version,
    we can fail the build.

    In environments that need the agent to inject the networking,
    you really want the agent to fail if it is not present.
    If the agent did not inject the networking, the server will
    have no networking.

    However, we can still leave the agent upgrade to silently
    fail, as the agent should be backwards compatible.

    fixes bug 1188540

    Change-Id: I8acdabd8d2bd24b088dad3cd4abec300d0ada3fb