Sync heartbeat 1:3.0.5-3.1 (main) from Debian unstable (main)

[Logan Rosen]

Please sync heartbeat 1:3.0.5-3.1 (main) from Debian unstable (main)

Explanation of the Ubuntu delta and why it can be dropped:
  * Drop unused build dependency on python-central.
The python-central build dependency was just removed from Debian as well.

Changelog entries since current saucy version 1:3.0.5-3ubuntu3:

heartbeat (1:3.0.5-3.1) unstable; urgency=low

  * Non-maintainer upload.
  * Complete transition to dh_python2 (Closes: #616841).

 -- Luca Falavigna <email address hidden> Thu, 30 May 2013 20:19:40 +0200

FTBFS
-----

ucast.c:468:6: error: conflicting types for 'i'
  int i = 1;
      ^
ucast.c:465:15: note: previous declaration of 'i' was here
  struct ifreq i;
               ^
ucast.c:502:11: error: request for member 'ifr_ifrn' in something not a structure or union
   strcpy(i.ifr_name, ei->interface);
           ^
ucast.c:508:7: error: request for member 'ifr_ifrn' in something not a structure or union
      i.ifr_name, strerror(errno));
       ^
ucast.c:513:5: error: request for member 'ifr_ifrn' in something not a structure or union
    i.ifr_name);
     ^

https://launchpadlibrarian.net/141874732/buildlog_ubuntu-saucy-amd64.heartbeat_1%3A3.0.5-3.1_FAILEDTOBUILD.txt.gz

[Jeremy Bícha (jbicha)]

This has been done but the new version doesn't build.

[Andres Rodriguez (andreserl)]

Hi Jeremy,

Thanks for taking care of the sync.

However, it is recommendable that you test build a package that you are about to sync in order to identify these type issues before they hit the archive. That way, we don't have a FTBFS package in the archive.

Thanks again

[Andres Rodriguez (andreserl)]

https://launchpad.net/ubuntu/+source/heartbeat/1:3.0.5-3.1ubuntu1

[Logan Rosen (logan)]

Andres, thanks for fixing the package, but, as a counter, packages that FTBFS in raring-proposed aren't a huge deal, especially since they let everyone see the build failure and attempt to fix it.

[Logan Rosen (logan)]

*saucy-proposed (hard to adjust to new release versions)

[Andres Rodriguez (andreserl)]

Hi Logan,

While it might not have been a huge deal, the package still FTBFS and this could have been spotted and fixed before the actual sync happened. This is why someone who manually syncs a package needs to make sure that the package builds before processing it. Not because we now have proposed, it means that it is ok to sync packages that FTBFS (because it is not).

I hope the clarification helps.

Regards.