Unused relay functionality in zmq driver

[Mark McLoughlin]

Just reviewing a patch, I notice:

class ZmqBaseReactor(ConsumerBase):

    def register(self, proxy, in_addr, zmq_type_in, out_addr=None,
                 zmq_type_out=None, in_bind=True, out_bind=True,
                 subscribe=None):
        ...
        if not out_addr:
            return
        ....
        self.mapping[inq] = outq
        self.mapping[outq] = inq
        ....

class ZmqProxy(ZmqBaseReactor):

    def consume_in_thread(self):

            self.register(consumption_proxy,
                          consume_in,
                          zmq.PULL,
                          out_bind=True)

class Connection(rpc_common.Connection):
    ...
    def create_consumer(self, topic, proxy, fanout=False):
        ...
        if fanout:
            sock_type = zmq.SUB
            ...
        else:
            sock_type = zmq.PULL
            ...

        self.reactor.register(proxy, inaddr, sock_type,
                              subscribe=subscribe, in_bind=False)

It seems like this functionality in the reactor to allow relaying incoming messages to another zmq client.

It looks like this functionality is completely unused and untested.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/31920

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/31920
Committed: http://github.com/openstack/oslo-incubator/commit/688832fd379776bf12f21f76c884caa42a48d2c5
Submitter: Jenkins
Branch: master

commit 688832fd379776bf12f21f76c884caa42a48d2c5
Author: Mark McLoughlin <email address hidden>
Date: Thu Jun 6 07:50:29 2013 +0100

    Remove unused zmq relay functionality

    Fixes bug #1188029

    This relay functionality appears to be completely unused and untested
    so just remove it. If we need it in future, we can restore it from the
    git history.

    Change-Id: I479d654aefdbd58c80946818b9a405eaa02644db