Need a way to expose and access common colors for a theme
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
High
|
Florian Boucault | ||
Ubuntu UX |
Fix Released
|
High
|
Katie Taylor | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The UITK should somehow expose the common colors that make up the current style’s visual identity, so that application authors can refer to those colors in their code without having to hardcode them.
An example of such a color is the Ubuntu Orange that’s tied to the Ambiance theme. In another theme, it might be a completely different color, but application developers shouldn’t have to care, they should be able to refer to this color by a named property and know that their applications will look right, regardless of the current theme.
I’m not sure how this should be exposed to application developers. Maybe a custom SystemPalette component (see http://
Related branches
- Tim Peeters: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1136 lines (+306/-118)42 files modifiedexamples/jokes/jokes.qml (+2/-2)
examples/locale/locale.qml (+2/-2)
examples/ubuntu-ui-toolkit-gallery/Dialog.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/ListItems.qml (+2/-2)
examples/ubuntu-ui-toolkit-gallery/ListItemsSection.qml (+6/-13)
examples/ubuntu-ui-toolkit-gallery/UbuntuShape.qml (+6/-6)
examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml (+1/-1)
modules/Ubuntu/Components/Label.qml (+1/-1)
modules/Ubuntu/Components/ListItems/Caption.qml (+9/-19)
modules/Ubuntu/Components/ListItems/Empty.qml (+1/-2)
modules/Ubuntu/Components/ListItems/LabelVisual.qml (+2/-1)
modules/Ubuntu/Components/ListItems/MultiValue.qml (+1/-0)
modules/Ubuntu/Components/ListItems/Standard.qml (+2/-4)
modules/Ubuntu/Components/ListItems/Subtitled.qml (+1/-0)
modules/Ubuntu/Components/ListItems/ValueSelector.qml (+1/-1)
modules/Ubuntu/Components/Panel.qml (+4/-4)
modules/Ubuntu/Components/Popups/ActionSelectionPopover.qml (+1/-0)
modules/Ubuntu/Components/Popups/Popover.qml (+1/-1)
modules/Ubuntu/Components/TextArea.qml (+5/-4)
modules/Ubuntu/Components/TextField.qml (+5/-4)
modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml (+2/-2)
modules/Ubuntu/Components/Themes/Ambiance/HeaderStyle.qml (+2/-2)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/NewTabBar.qml (+8/-3)
modules/Ubuntu/Components/Themes/Ambiance/Palette.qml (+45/-0)
modules/Ubuntu/Components/Themes/Ambiance/PointerStyleShader.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/PopoverForegroundStyle.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/ScrollbarStyle.qml (+1/-3)
modules/Ubuntu/Components/Themes/Ambiance/SliderStyle.qml (+3/-9)
modules/Ubuntu/Components/Themes/Ambiance/SwitchStyle.qml (+3/-3)
modules/Ubuntu/Components/Themes/Ambiance/TabsStyle.qml (+2/-6)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-4)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-2)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarButtonStyle.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarStyle.qml (+1/-3)
modules/Ubuntu/Components/Themes/Palette.qml (+59/-0)
modules/Ubuntu/Components/Themes/PaletteValues.qml (+72/-0)
modules/Ubuntu/Components/Themes/Themes.pro (+11/-0)
modules/Ubuntu/Components/Themes/qmldir (+3/-0)
modules/Ubuntu/Components/plugin/uctheme.cpp (+26/-1)
modules/Ubuntu/Components/plugin/uctheme.h (+6/-0)
tests/unit_x11/tst_components/tst_textfield.qml (+0/-8)
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ux: | |
assignee: | nobody → Calum Pringle (calumpringle) |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Florian Boucault (fboucault) |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Calum Pringle (calumpringle) → Katie Taylor (katie-t) |
Changed in ubuntu-ux: | |
status: | Confirmed → Fix Committed |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
The Ubuntu Colour Palette: http:// design. ubuntu. com/brand/ colour- palette.