instance directory naming update to use uuid

Bug #1186944 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Yaguang Tang
Grizzly
Fix Released
Medium
Gary Kotton
VMwareAPI-Team
Fix Released
Critical
Unassigned

Bug Description

The VMware Hyper still use instance-000000xx template to name instance directory. which will face the same problem that libvirt
faces. so change the directory naming of VMware Hyper.

Tags: vmware
Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
tags: added: vmware
Revision history for this message
dan wendlandt (danwent) wrote :

if you are going to change the name of the instance directory, we should probably change the name of the instance itself as well. This is the primary means by which the VM is identified for later changes, as the driver does not store any vCenter UUIDs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/31593

Changed in nova:
status: New → In Progress
Revision history for this message
Shawn Hartsock (hartsock) wrote :

We were just discussing this in a VMwareAPI team meeting last week. We wanted the name of the instance in vCenter to be the UUID instead of the hidden ID number. Using instance-000000xx as the instance name actually exposes implementation details from inside OpenStack to vCenter (and that's a bad thing). I would like this to be part of a larger patch that addressed both issues.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/31593
Committed: http://github.com/openstack/nova/commit/e517e5668ab20214432e06ef87f7b16776edaf7c
Submitter: Jenkins
Branch: master

commit e517e5668ab20214432e06ef87f7b16776edaf7c
Author: Yaguang Tang <email address hidden>
Date: Wed Jun 5 15:16:16 2013 +0800

    Naming instance directory by uuid in VMware Hyper.

    Like Libvirt Hyper, Using EC2 template for naming instance
    directory may cause conflict. we follow what Libvirt does to use
    instance uuid instead of EC2 template naming. To keep backwards
    compability, when fails to find a instance by uuid, fall back to use
    EC2 name.

    Fix bug #1186944

    Change-Id: Iaba099225a9b3b0390cae4c5fbd82d7e6c11f0e0

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
importance: Undecided → Medium
milestone: none → havana-2
Revision history for this message
Shawn Hartsock (hartsock) wrote :

I want to see this back ported. This is the right way for the driver to work.

tags: added: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/38043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/38043
Committed: http://github.com/openstack/nova/commit/7ad1db6140c49c85ba643a6217878ef8f3d30463
Submitter: Jenkins
Branch: stable/grizzly

commit 7ad1db6140c49c85ba643a6217878ef8f3d30463
Author: Yaguang Tang <email address hidden>
Date: Wed Jun 5 15:16:16 2013 +0800

    Naming instance directory by uuid in VMware Hyper.

    Like Libvirt Hyper, Using EC2 template for naming instance
    directory may cause conflict. we follow what Libvirt does to use
    instance uuid instead of EC2 template naming. To keep backwards
    compability, when fails to find a instance by uuid, fall back to use
    EC2 name.

    Fix bug #1186944

    (cherry picked from commit e517e5668ab20214432e06ef87f7b16776edaf7c)

    Conflicts:

     nova/tests/vmwareapi/db_fakes.py
     nova/virt/vmwareapi/vmops.py

    Change-Id: Iaba099225a9b3b0390cae4c5fbd82d7e6c11f0e0

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Tracy Jones (tjones-i)
tags: added: vmware-co-preferred
removed: vmware
tags: added: vmware
tags: removed: vmware-co-preferred
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
status: New → Fix Released
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
importance: Undecided → Medium
Changed in openstack-vmwareapi-team:
importance: Medium → High
importance: High → Critical
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.