Adding time entries is broken at the end of month

[Ingo van Lil]

There is a problem with adding new time entries at the end of the month, i.e. when the current day of month is above 28. Today I tried to create a time entry for last month, and the form would not let me select April in any of the date pickers. It would always change the field to May. Selecting any other month with less than 31 days was also not possible.

The problem is caused by the makeDate() function in htdocs/js/global.js: The code creates a new Date object (which automatically is set to the current date) and successively sets the year, month and day on this object. Calling setMonth() will result in an invalid date when the current day is 31 and the new month has less than 31 days.

Fixing the bug is trivial: Starting with JavaScript version 1.3 (i.e. since 1998 according to Wikipedia) the setMonth() call has an optional day parameter which sets month and day at the same time. See attached patch for details.

[Elan Ruusamäe (glen666)]

applied in

http://bazaar.launchpad.net/~eventum-developers/eventum/trunk/revision/4581
https://github.com/eventum/eventum/commit/edd0a869dba99541e6a7b42ff28826b9bece0429