password is changed even if left blank when editing user

Bug #1186160 reported by Jan Provaznik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Zhenguo Niu

Bug Description

with keystone v3 only
if I update a user on admin's edit user page and I omit setting password (IOW left blank), the password is set anyway.
Expected behavior: password is not changed in this case.

Changed in horizon:
assignee: nobody → Jan Provaznik (jan-provaznik)
Kieran Spear (kspear)
Changed in horizon:
status: New → Confirmed
milestone: none → havana-2
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/31479

Changed in horizon:
assignee: Jan Provaznik (jan-provaznik) → 牛振国 (niu-zglinux)
status: Confirmed → In Progress
Revision history for this message
Jan Provaznik (jan-provaznik) wrote :

@niu-zglinux: thanks for sending a patch. Only a nit: next time please try contact the owner of the bug on irc or by mail before you take assigned bug and ask him if it's OK to reassign the bug. In this case it's not a big deal, but in other cases it causes pointless duplication of work (e.g. https://review.openstack.org/#/c/30845/).

Revision history for this message
Kieran Spear (kspear) wrote :

Agreed. Please don't reassign bugs without permission from the assignee.

Revision history for this message
Kieran Spear (kspear) wrote :

Added keystone in case they want to do something about this too.

Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :

Sorry for that Jan Provaznik. I'll get the permission first next time.

@Kieran Spear It's no need to add keystone here.

Dolph Mathews (dolph)
Changed in keystone:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :

It's a horizon problem when calling user update method.
password is changed in this case because dashboard pass a data include a blank passwod to user_update.

Revision history for this message
Dolph Mathews (dolph) wrote :

Ah, thanks for the clarification- removing keystone then.

no longer affects: keystone
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/31479
Committed: http://github.com/openstack/horizon/commit/3eac9180a9a2676ec9fc81e2545289f840b7603c
Submitter: Jenkins
Branch: master

commit 3eac9180a9a2676ec9fc81e2545289f840b7603c
Author: Zhenguo Niu <email address hidden>
Date: Mon Jun 3 17:04:47 2013 +0800

    Pop 'password' in user_update v3 if it is left blank

    password should not be changed when update user with password left blank

    Fixes: bug #1186160

    Change-Id: I24daa4ad05f0659e0aa06e469b0eb777f1595603

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.