Unity API

Unity-api installs a file called config.h

Bug #1185319 reported by Jussi Pakkanen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity API
Fix Released
Undecided
Michi Henning

Bug Description

Unity-api installs a file called config.h in a public directory. This is bad form, because almost all projects use an internal config.h file that they generate themselves. This can lead to #include collisions. This file should either be renamed unity-config.h or similar or it should not be installed.

Related branches

lp:~michihenning/unity-api/rename-config
PS Jenkins bot (community): Approve (continuous-integration)
Jussi Pakkanen (community): Approve
Diff: 275 lines (+14/-115)
14 files modified
include/unity/Exception.h (+1/-1)
include/unity/SymbolExport.h (+2/-2)
include/unity/api/Version.h.cmake (+0/-101)
include/unity/api/Version.h.in (+1/-1)
include/unity/shell/notifications/Enums.h (+1/-1)
include/unity/shell/notifications/ModelInterface.h (+1/-1)
include/unity/shell/notifications/NotificationInterface.h (+1/-1)
include/unity/shell/notifications/SourceInterface.h (+1/-1)
include/unity/util/FileIO.h (+1/-1)
include/unity/util/NonCopyable.h (+1/-1)
test/qmltest/mocks/plugins/Unity/Notifications/Mocks/MockActionModel.h (+1/-1)
test/qmltest/mocks/plugins/Unity/Notifications/Mocks/MockModel.h (+1/-1)
test/qmltest/mocks/plugins/Unity/Notifications/Mocks/MockNotification.h (+1/-1)
test/qmltest/mocks/plugins/Unity/Notifications/Mocks/MockSource.h (+1/-1)
Revision history for this message
Michi Henning (michihenning) wrote :

Yes, agree, probably best not to install it. I don't think there is anything in there that would be needed by the API customer.

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

In NonCopyable.h there is this:

#include <unity/config.h>

It may be in others as well.

Revision history for this message
Michi Henning (michihenning) wrote :

Silly me, you are right. We'll have to rename it then.

Michi Henning (michihenning)
Changed in unity-api:
assignee: nobody → Michi Henning (michihenning)
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-api at revision 56, scheduled for release in unity-api, milestone Unknown

Changed in unity-api:
status: In Progress → Fix Committed
Michi Henning (michihenning)
Changed in unity-api:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.