dpkg/DebSrc3.0 should accept git-format-patch output (or error out)

[Björn Michaelsen]

dpkg/DebSrc3.0 patches should accept git format-patch output. In most cases this is done, which causes even more confusion if it doesnt, e.g. for this commit:

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=faf72664d11deaa570a0f8c7e702ff07bf5914c8

git writes the diff base filename for the newly-created file as a/dev/null.

Observed behaviour:
The debian toolchain does neither abort hard on this, nor create the file as one would expect.

Expected behaviour:
A hard abort on such a patch in debian/patches/ or (better): handling such patches as git does.

[Dimitri John Ledkov (xnox)]

Direct link to raw patch:
http://cgit.freedesktop.org/libreoffice/core/patch/?id=faf72664d11deaa570a0f8c7e702ff07bf5914c8

[Dimitri John Ledkov (xnox)]

If one goes into libreoffice git checkout and executes:
git format-patch faf72664d11deaa570a0f8c7e702ff07bf5914c8^..faf72664d11deaa570a0f8c7e702ff07bf5914c8

the generated patch has the following headers for the newly created file:
diff --git a/liborcus/liborcus_0.1.0-boost-include.patch.1 b/liborcus/liborcus_0.1.0-boost-include.patch.1
new file mode 100644
index 0000000..07558b0
--- /dev/null
+++ b/liborcus/liborcus_0.1.0-boost-include.patch.1

But freedesktop cgit web-interface generates "/a/dev/null". Maybe it's a bug in cgit or git as installed on freedesktop.org?

[Björn Michaelsen (bjoern-michaelsen)]

Hmmm, indeed the good gitweb installation on TDF infra seems to get it right:
https://gerrit.libreoffice.org/gitweb?p=core.git;a=patch;h=faf72664d11deaa570a0f8c7e702ff07bf5914c8