AttributeError: 'TestRun' object has no attribute 'setKernelState' when running checkbox-certification-submit.

Bug #1185026 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
checkbox-certification
Won't Fix
Medium
Brendan Donegan

Bug Description

When trying to send a submission with checkbox-certification-submit, the following traceback is displayed:

AttributeError: 'TestRun' object has no attribute 'setKernelState'

This appears to be harmless since the submission is made and processed succesfully. However the presence of this traceback may be a cause of concern for those not familiar with the reason so we need to get rid of it.

Related branches

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

This is caused by some redundant code which handles sending 'messages' to the (old) certification site. This is dead code that just gets in the way, so we should purge all the code that is not being used.

affects: ubuntu → checkbox
affects: checkbox → checkbox-certification
Changed in checkbox-certification:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Brendan Donegan (brendan-donegan)
Revision history for this message
Daniel Manrique (roadmr) wrote :

This is actually on the certification website side, the checkbox submission parser in the hexr source tree lacks this method, I ran into this when debugging the parser for the devices problem.

I worked around it by adding this method:

=== modified file 'apps/uploads/checkbox_parser.py'
--- apps/uploads/checkbox_parser.py 2012-11-21 16:58:07 +0000
+++ apps/uploads/checkbox_parser.py 2013-05-24 17:47:41 +0000
@@ -51,6 +51,11 @@
             "memory": memory})
         logger.debug("Seting memory amount: %s", memory)

+ def setKernelState(self, kernel):
+ self.messages.append({
+ "type": "set-kernel",
+ "kernel": kernel})
+

More subtle changes may be needed on the c4 side but this is a start.

Revision history for this message
Daniel Manrique (roadmr) wrote :

Oops, actually scratch that, there *is* a TestRun class in checkbox-certification-submit which potentially shares the same issue I describe. damn where's the "delete comment" button...

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Actually I added setKernelState there already, if you get the latest code in trunk for HEXR.

Daniel Manrique (roadmr)
Changed in checkbox-certification:
status: In Progress → Fix Committed
Jeff Lane  (bladernr)
Changed in checkbox-certification:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.