Rename the "Reload from Musicbrainz" option in the context menu

Bug #1184157 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
jus

Bug Description

Tested with lp:trunk

The "Reload from Musicbrainz" option in the context menu is pretty much non descriptive and should be changed to something like "Get Track Metadata" or "Lookup Metadata online".

Why?
Because it describes what the option actually does. It also implies that an online connection is required. Most users dont care what kind of online service we use for retrieving the data as long it is reliable, so attribution is not even required at this point.

Tags: metadata
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Max Linke (max-linke) wrote :

hm then we should also change the 'Reload Track Metadata' to something that makes it clear that they are reloaded from the file.

Actually I would also remove both from the context menu and only make them available in the properties windows.
This makes the context menu nice and small plus track metadata can't be changed by accident

jus (jus)
Changed in mixxx:
assignee: nobody → jus (jus)
milestone: none → 1.12.0
status: Confirmed → In Progress
Revision history for this message
jus (jus) wrote :

Here is a small patch that does the following:
* Add separator in the context menu to group metadata related menu points
* Rename available options to "Reload Metadata from File" and "Get Metadata from MusicBrainz"
   Since all options in this menu are somehow related to a track, it was reasonable to drop the extra
   "track" from both menu points.
  In response to #1, I would like leave both options in. Mostly for the reason that you can reload
  metadata from multiple files, something you can't do with the current property editor.
* In the MusicBrainz fetcher dialog:
   - Add descriptive Title to the dialog window
   - Add some translator comments
   - Change Song -> Track
   - Change button order to be like in the Tracks Properties dialog
   - Use Ampersands (&) for button text to quickly access that particular GUI element.
   - Fix tab order.
* In the Tracks Properties dialog, metadata buttons are now in the same order like in the context menu. Also fix tab order.

Revision history for this message
jus (jus) wrote :
Revision history for this message
Max Linke (max-linke) wrote :

LGTM

Revision history for this message
jus (jus) wrote :
jus (jus)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7052

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.