holland advisory lock failures

[Andrew Garner]

holland 1.0.8 introduced a bug when two holland process try to run the same backupset simultaneously. This results in an ugly stacktrace along the lines of:

2013-05-22 21:27:59,380 [ERROR] Uncaught exception while running command 'backup': <exceptions.AttributeError instance at 0x1d898998>
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/holland/core/command/command.py", line 209, in dispatch
    return self.run(self.optparser.prog, opts, *args)
  File "/usr/lib/python2.4/site-packages/holland/commands/backup.py", line 95, in run
    lock.path, lock.lock.name)
AttributeError: 'NoneType' object has no attribute 'name'

[Andrew Garner (muzazzi)]

This was introduced when the lock messages were made a little more user friendly - but obviously there isn't a test for this.

Fixed here:

https://github.com/holland-backup/holland/commit/aeeff5ad92246c1f33a6496c278cbcd37792a89b

The proper output here should be:

Holland 1.0.8 started with pid 26836
--- Starting backup run ---
Another holland backup process is already running backupset 'default'. Aborting.
--- Ending backup run ---

This needs to be added to the test suite.