Default filter option for configuration screens

[Steven Chan]

In the staff client, the AutoGrid widget is used to render configuration lists, and by default, the setting 'showLoadFilter' is turned off. It seems more useful to turn it on by default so that any configuration screen can use it unless its template sets it off.

Evergreen version.2.2

[Pasi Kallinen (paxed)]

Signoff at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e9a2b3d9cfd510cef6d8f5f66710516d43ce259d

[Ben Shum (bshum)]

Tested this and while it does add the filter option to all the configuration screens, I've noticed that once you set a set of filters, it doesn't seem to change if you alter the filters.

For example, I log in and look at the hold policies and then say set to filter for owning library is a specific lib from the dropdown and a specific circ modifier. It'll filter and only show me that library and that circ modifier. Then if I click filter again and say change the circ modifier to a different one and click apply, it doesn't update the screen. Instead it shows me the same filter as what I had initially chosen.

I can repeat that with all the interfaces where a new filter was added, where it'll stick to the first filter I apply instead of switching to new filters if I edit the options a moment later.

By default, the filter option that's already present in some of the acq configuration interfaces like funds or providers works and changes if I alter the filters after an initial setting. So there must be another piece at play here that we're still missing.

[Pasi Kallinen (paxed)]

Ben, I think I've now fixed that (or at least it now works for anything I've tested). Branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/lp1183553

Apparently the filter dialog kept the previous filter around and then joined the new one with it ...

[Ben Shum (bshum)]

Preliminary testing with the line change added by paxed shows that it works with altering the filters appropriately when applied. Existing filters in the acq funds, etc. seem to be fine and not broken by the change so far.

Doing some more tests later today, but looks ready to be pushed through to master.

[Ben Shum (bshum)]

Pushed to master as two commits. Thanks Pasi!