OPAC patron opt-in settings table does not work correctly

Bug #1183414 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.3
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

*EG master

The opt-in user settings table (in Open-ILS/src/templates/opac/myopac/prefs_notify.tt2) does not work. The template code is trying to use the variable optin before it's defined. It will never show the "No notification preferences are configured" -text. It will always show the table headers, even when there's nothing to show in the table.

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Pasi Kallinen (paxed) wrote :

Fix at user/paxed/opac-fix-user-optin-table

tags: added: pullrequest
Pasi Kallinen (paxed)
Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Bill Erickson (berick) wrote :

Tested, merged, and back-ported through 2.3. Thanks, Pasi!

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: Triaged → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.