ACQ, VIEW_FUND, permission issue 2.3.4

[Steve Callender]

When a user has just the VIEW_FUND permission and not the ADMIN_ACQ_FUND permission, (to allow the users to just view the funds and not edit them), an error occurs on the system that causes none of the funds to display.

It looks like the code tries to sort editable entries, and when you can only VIEW them, there is nothing to sort causing the list to be empty. Here is an example log,

open-ils.pcrud open-ils.pcrud.search.acqf "(removed token)", {"year":"2013","org":[4]}, {"order_by":[{"class":"acqf","field":"org","compare":{"in":[]},"direction":"desc"},{"class":"acqf","field":"name"}],"limit":15,"flesh":1,"flesh_fields":{"acqf":["spent_balance","combined_balance","spent_total","encumbrance_total","debit_total","allocation_total"]}}

Notice above the compare "in" list is empty. This causes the following error,

open-ils.pcrud: Empty IN list

Looks like we need to avoid this sort if the user can't edit any funds and only view.

Steve

[Bill Erickson (berick)]

Fix pushed to working/user/berick/lp1183340-acq-fund-list-perm-repair

[Steve Callender (stevecallender)]

Bill,

I tested your patch on a 2.3.4 test system and it worked perfectly.

Steve

[Dan Wells (dbw2)]

Tested, pushed back through 2.3. Thanks, Bill and Steve!