table actions with preempt = True get called twice

Bug #1182661 reported by Eric Peterson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ladislav Smola

Bug Description

It looks like the table actions with preempt=True get called twice, once during the maybe_preempt and the other time with normal action handling. It seems like the normal action handling should ignore preempt actions that have already been fired.

Changed in horizon:
assignee: nobody → Harshavardhan Reddy M (hvreddy1110)
Changed in horizon:
status: New → Confirmed
Changed in horizon:
assignee: Harshavardhan Reddy M (hvreddy1110) → nobody
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
Ladislav Smola (lsmola)
Changed in horizon:
assignee: nobody → Ladislav Smola (lsmola)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45038

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Ladislav Smola (lsmola) wrote :

Eric Peterson: can you try it with your code? I haven't actually tried it with preemptive actions, seems like normal actions passes. So does tests.

Changed in horizon:
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/45038
Committed: http://github.com/openstack/horizon/commit/3548435547957bc79c034a90b35405831501cafc
Submitter: Jenkins
Branch: master

commit 3548435547957bc79c034a90b35405831501cafc
Author: Ladislav Smola <email address hidden>
Date: Wed Sep 4 13:56:19 2013 +0200

    Do not run preemptive actions twice

    When table action is preemptive , it needs to run
    only once, before the table data is loaded.

    Fixes bug 1182661
    Change-Id: Ibb7ed5f97f64cfc9e56b317ed9d4b5e8cbf8cc8c

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.