external download manager - commandline improperly handles nullable strings
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
To reproduce (with latest git, vala 0.20), enable the "external download manager - Commandline" extension. Then try to download the file <http://
(midori4:31433): GLib-CRITICAL **: g_shell_quote: assertion `unquoted_string != NULL' failed
** (midori4:31433): CRITICAL **: string_replace: assertion `replacement != NULL' failed
** (midori4:31433): CRITICAL **: string_replace: assertion `self != NULL' failed
** (midori4:31433): CRITICAL **: string_replace: assertion `self != NULL' failed
(midori4:31433): GLib-CRITICAL **: g_spawn_
The attached patch fixes these warnings and makes the download manager run.
Related branches
- André Stösel: Approve
-
Diff: 34 lines (+7/-7)1 file modifiedextensions/external-download-manager.vala (+7/-7)
Changed in midori: | |
milestone: | none → 0.5.2 |
Changed in midori: | |
status: | New → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |