external download manager - commandline improperly handles nullable strings

Bug #1182304 reported by gue5t gue5t
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

To reproduce (with latest git, vala 0.20), enable the "external download manager - Commandline" extension. Then try to download the file <http://nxzobi.people.wm.edu/ext1.pdf> (click, then select "save" in the download dialog). The following errors are printed:

(midori4:31433): GLib-CRITICAL **: g_shell_quote: assertion `unquoted_string != NULL' failed

** (midori4:31433): CRITICAL **: string_replace: assertion `replacement != NULL' failed

** (midori4:31433): CRITICAL **: string_replace: assertion `self != NULL' failed

** (midori4:31433): CRITICAL **: string_replace: assertion `self != NULL' failed

(midori4:31433): GLib-CRITICAL **: g_spawn_command_line_async: assertion `command_line != NULL' failed

The attached patch fixes these warnings and makes the download manager run.

Related branches

Revision history for this message
gue5t gue5t (gue5t) wrote :
Changed in midori:
milestone: none → 0.5.2
RabbitBot (rabbitbot-a)
Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.