live migration error notification do not include vm uuid

[Guangya Liu]

Take a look at scheduler/manager.py:live_migrate

def live_migration(self, context, instance, dest,
                       block_migration, disk_over_commit):
        try:
            return self.driver.schedule_live_migration(
                context, instance, dest,
                block_migration, disk_over_commit)
        except (exception.NoValidHost,
                exception.ComputeServiceUnavailable,
                exception.InvalidHypervisorType,
                exception.UnableToMigrateToSelf,
                exception.DestinationHypervisorTooOld,
                exception.InvalidLocalStorage,
                exception.InvalidSharedStorage,
                exception.MigrationPreCheckError) as ex:
            request_spec = {'instance_properties': {
                'uuid': instance['uuid'], },
            }
            with excutils.save_and_reraise_exception():
                self._set_vm_state_and_notify('live_migration',
                            dict(vm_state=instance['vm_state'],
                                 task_state=None,
                                 expected_task_state=task_states.MIGRATING,),
                                              context, ex, request_spec)
        except Exception as ex:
            with excutils.save_and_reraise_exception():
                self._set_vm_state_and_notify('live_migration',
                                             {'vm_state': vm_states.ERROR},
                                             context, ex, {}) <<<< request_spec is {}, this will cause the notification do not include vm uuid and the receiver do not know which VM goes to ERROR state

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/29918

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/29918
Committed: http://github.com/openstack/nova/commit/f396f75d14f9da97a566e2e5607f537b07a6803a
Submitter: Jenkins
Branch: master

commit f396f75d14f9da97a566e2e5607f537b07a6803a
Author: Jay Lau <email address hidden>
Date: Tue May 21 20:56:06 2013 +0800

    Put VM UUID to live migration error notification

    If live migration encounter some exception before nova scheduler
    cast message to nova compute, nova scheduler will set the VM state
    to ERROR and send notification, but the notification do not include
    VM UUID, this might cause some problem if some components want to
    handle the notification since those components will not able to know
    the VM UUID about the notification.

    The solution is add UUID to live migration error notification so other
    components can get the related notification correctly.

    Fix bug 1182117

    Change-Id: Id101f9e2a689a02d1604c12cd7677e0975bd7428