account-reaper loops forever on empty string objectname

[Donagh McCabe]

I found a folder where the object name is an empty string. Not sure how that is possible.. In any event, account.reaper.reap_container loops forever because having called direct_get_container(), it set's the marker to '' and calls direct_get_container().. which returns the first object again.

[Donagh McCabe (donagh-mccabe)]

Also, it would be nice if account-reaper logged when it has not cleaned up a long time after the account was deleted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/29789

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/29789
Committed: http://github.com/openstack/swift/commit/34e2ab3f31ff039359e35c8a41197b5cf7af8156
Submitter: Jenkins
Branch: master

commit 34e2ab3f31ff039359e35c8a41197b5cf7af8156
Author: Donagh McCabe <email address hidden>
Date: Mon May 20 16:52:54 2013 +0100

    account-reaper warns if not making progress

    DocImpact
    If account reaper has not managed to clean out an account after a long
    period, it prints a message to the log (you can search your system looking
    for such messages). Introduce reap_warn_after config variable to determine
    when to emit the message (defaults to 30 days).

    Also fix bug 1181995 (edge case where object name is an empty string)

    Change-Id: Ic0dfee04742d06b6a51b59f302d7a272d7c1de92