Segfault when icons not found in current theme

[Adam Mills]

I've installed pantheon-greeter on my gentoo box using the elementary-overlay maintained here: https://github.com/pimvullers/elementary

When pantheon-greeter is installed without the elementary-icon-theme package, some icons cannot be loaded. In my case, "avatar-default", "system-shutdown-symbolic", and "preferences-desktop-accessibility-symbolic" could not be found.

When pantheon-greeter attempts to use these icons, it crashes with a segfault.

I've attached a patch that prevents the greeter from crashing when these icons aren't present; however, this means that the power and accessibility icons aren't rendered. Preferably the buttons would be replaced with text, but I'm not familiar enough with the greeter code to make that change.

[Arturo Torres Sánchez (r2d2.art2005)]

I think a better approach would be to include those icons with the package in case the default ones can't be found.

[Adam Mills (m04y68q005su1-adam)]

That seems like a better solution.

Thinking about it further, creating text alternatives is probably too much work for this unusual situation. If the icons aren't included in this package, it should probably just print an error to the log and move on.

[Raphael Isemann (teemperor)]

I'm not sure about adding all those icons to the package, but preventing crashed due to missing icons is a valid bug.