Icons with cross are too small. Make them bigger to be more functional and look more proffesional

[grofaty]

I have been working with Pinta-1.5-preview-20130518 and I see benefit of using special icons for RectangleSelect and EllipseSelect instead of classical mouse pointer icon, but I see small cross at this icons little bit unclear.

It would be better to have bigger crosses.

P.S. Mark a bug as wishlist.

[grofaty (grofaty)]

I have been playing around and combining elements from existing icons. I came out with the following icons.

[grofaty (grofaty)]

Please note I have moved position of mouse cursor cross to left-bottom, so some program code should also change if this icons are applied.

[grofaty (grofaty)]

Please ignore icons from #1 and #2 and use bellow one.

[grofaty (grofaty)]

I have rebuild Pinta from source code and cursor focus should be changed.

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

Cameron, if you want this change in, you can assign it to me and I will replace the icons with the ones provided by grofaty and make any required code changes.

[grofaty (grofaty)]

Uhhhh... tested icons on black background and this icons are not good. Probably the best to not change icons until I (or someone else) get some idea how to get them better.

[grofaty (grofaty)]

I have been playing around and didn't find any good solution... then looked at Gimp and then I got it. Gimp is using bigger icons. It is very very very hard to create small icons, they will almost always look ugly and/or too small to be beautiful.

Now I have been playing around and created 32x32 px mouse icons and I think they look excellent - the only big difference is they are just bigger. I recompiled Pinta with new icons and bellow is attachment. First row there are current Pinta icons (on white and black background) and second row are new 32x32 px icons (on white and black background).

[grofaty (grofaty)]

Can someone please write in which source file is required to change exact acceptance of cursor action. I would like to change this settings in source code and recompile to see how good new icons are.

[grofaty (grofaty)]

Please ignore icons from #21 and #22.

[grofaty (grofaty)]

Now I see Ellipse cursor and RoundedRectangle currently have in Pinta the same icon.

Icon from #15 should be renamed Cursor.Ellipse.png and write a code to accept this icon for ellipse cursor.
Bellow I will attach the Cursor.RoundedRectangle.png file.

[grofaty (grofaty)]

I have finished all of the icons. So please do the following:
a) Download icons from this bug tracker posts: #10, #11, #12, #13, #14, #15 (rename this icon to Cursor.Ellipse.png and enable it in Pinta to have ellipse its own icon - currently Ellipse and RoundedRectangle are using the same icon), #16, #17, #18, #19, #24, #25, #26, #27 and #29.
b) Copy this icons to source code folder \Pinta.Resources\Resources
c) Modify a soure code to accept new cursor focus.

I suggest to mark this bug report as Wishlist and create a milestone 1.5. I am also adding easy-to-fix tag. I really think this new icons are way way more beautiful and useful.

[grofaty (grofaty)]

See attachment. I have created comparison of cursor icons. Left site 'current mouse icons' and right site 'new suggested icons'.

P.S. The icons that haven't changed are not included in image.

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

I like the new icons a lot. Some of them also have the high quality color version (e.g. Pencil tool) compared to the black and white version that is used now. Cameron, Robert, should we put these in? I can do it for Pinta 1.5 or we can leave it for Pinta 1.6. It's up to you!

[grofaty (grofaty)]

@Elvis, there is approval in mailinglist post: https://groups.google.com/forum/?hl=en&fromgroups=#!topic/pinta/BS_7SfnjMCg
by Cameron and Robert for 1.5. So if you are willing to do this, please assign yourself to do the tast. Thanks.

[grofaty (grofaty)]

Cam, can you add to this bug:
a) Milestone: 1.5
b) Assigned to: Elvis Alistar (ealis2001)
c) Importance: Medium
d) Status: Triaged

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

I will change the icons tomorrow or the day after tomorrow (I need to get the code for Pinta on my Mac). My Windows machine currently fails me.

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

I made the changes and made the pull request: https://github.com/PintaProject/Pinta/pull/60. But, I have one problem with the new solution. The 32x32 icons look great, but now we have a mix of 16x16 and 32x32 icons, since some of the old ones did not get a bigger version. I think those should be reworked in 32x32 sizes and also added in for Pinta 1.5. The list of icons that are not 32x32 after my change: Cursor.CloneStampSetSource, Cursor.MagicWand, Cursor.PaintBucket and Cursor.Text (though I think this last one is not really needed). The following tools need a 32x32 cursor icon (right now they reuse the tool icon): Eraser, Move, MoveSelection, PaintBrush and Pan.

Cameron, what do you think? Should grofaty or someone else try to create these icons? Should I open a different bug about it, since this one was only about the icons with cross, which is now fixed?

[Cameron White (cameronwhite91)]

I'd say yes - the icons should all be consistent

[grofaty (grofaty)]

Yes, we now have 16 x 16 icons (that did not change) and 32 x 32 icons (that did change). I will make the icons suggested in #36 the same size 32 x 32. I agree consistency is nice habit. :)

[grofaty (grofaty)]

I have completely redesigned Move and MoveSelection icons. Currently when using Pinta I am always wondering which icon I have to click for Move and which one for MoveSelection. This two icons are so similar that is difficult to distinguish.

For Move I have designed the 'Gimp way' icon. For MoveSelection I have created new icon which is somehow combination of Rectangle Select and Move Selected Pixel. I think this icons are better and more meaningful. Hope you like them.

P.S. For this two icons (Move and MoveSelection) I have also created Tools icons to reflect changes.

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

Thanks, grofaty! All tool icons are now updated. Pull request pending review and approval from Cameron.

[grofaty (grofaty)]

Elvis, I have also find out some problems with selection tool. We are using Pan icon for resize rectangle/ellipse/lasso selection. I have created three new icons and uploaded them to new bug 1188143 (related to that problem). Can you look at them and if possible change underlining code?

[grofaty (grofaty)]

Elvis, I have downloaded you changes to this bug report from https://github.com/ericksson/Pinta/archive/master.zip and compiled on Windows XP. I see you did a great job. I have tested all of the icons and it appears to me there is no problem.

P.S. You didn't include icons from #46 to #49. You probably not even spotted this icons, because I have uploaded them latter. Should we wait for Cameron approval if we want to change Move Selected Pixels and Move Selection icons. Cameron what do you think about icons #46 to #49 - can we replace them with current icons?

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

grofaty, I did spot the new icons from #46 to #49, but I'm not sure if those should be changed or not. I am waiting for Cameron's opinion. Also waiting for his opinion on bug 1188143. If we use the Pan cursor in the situations you are describing, then I agree we should have different icons. If Cameron agrees on that, too, he can assign the new bug to me and I will include everything in the pull request (so what started as replacing a few icons ends up in a rework of all the cursor icons :-) )

[Cameron White (cameronwhite91)]

I commented on bug #1188143 .

I'm not a huge fan of the new Move Selection icon, since I find it a bit too similar to the selection tool icons. I rather leave stuff like that for after 1.5, since redesigning icons is a more lengthy task than simply resizing icons.

[grofaty (grofaty)]

Cameron, I understand your point. This bug report is for having small crosses in icons and so difficult to work with them and solution is to enlarge the icons and this was done. No point of holding back the Pinta 1.5 release for redesign of icons. Probably redesign of icons should be discussed on mailing list.

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/pull/60

[grofaty (grofaty)]

As I see we agreed upon the tasks in this bug request. So the only think left is merging the code from Elvis pull request: https://github.com/PintaProject/Pinta/pull/60

[grofaty (grofaty)]

Funny I typed in what to do in #57 exactly in the same minute you have already done the mask #56.

I have now downloaded latest source code and compiled on Windows XP and have done some test with this icons as I already did with Elvis source code and I can report I haven't spotted any error. So this icons are working without a problem.

Elvis thanks for writing code and Cameron thanks to merging into master.