MARC Editor Authority Validation Needs Repair

Bug #1180840 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned

Bug Description

Confirmed in 2.3+, but may also affect 2.2.

Clicking the Validate button in the MARC editor never results in invalid controlled fields. In other words, non of the controlled fields ever turn red to indicate they are invalid. The JS appears to be expecting a different data structure than it's receiving. Investigation further...

Revision history for this message
Bill Erickson (berick) wrote :

working/user/miker/authority-validation-sf-format

working/collab/berick/marc-edit-authority-validate-repairs

Revision history for this message
Bill Erickson (berick) wrote :

Two patches with sign-offs pushed to user/berick/authority-validation-sf-format-signoffs

I'll merge to 2.3+ and ping Lebbeous about 2.2.

Changed in evergreen:
milestone: none → 2.4.1
no longer affects: evergreen/2.2
Changed in evergreen:
status: New → In Progress
status: In Progress → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Revision history for this message
Mike Rylander (mrylander) wrote :

I've combined these branches into a single one with some improved commit messages for my part. Signoffs from Bill and myself are available at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/authority-validation-sf-format-signoffs

Top two commits.

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Targeting 2.2 as is likely affects 2.2 as well. Confirmation needed. (Note, the branch in comment #2 is fully signed off. Safe to ignore Mike's final comment, which preceded mine IRL).

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Testing 2.2 and I see red!

Thanks, merged to rel_2_2.

Revision history for this message
AlexK (alex-kent) wrote :

Tested in 2.3.7 and it worked!

Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.