[7.0] hr_timesheet_sheet - attendances can be added on waiting approval and approved timesheets
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Low
|
OpenERP Publisher's Warranty Team | ||
Bug Description
Tested on runbot
(Build 11071)
server (4975)
addons (9132)
web (3922)
Using "Track attendances for all employees" in HR settings
If you send a timesheet in approval a bit early, you will still be able to sign in and sign out on that timesheet.
Well we can discuss on this as it is in a field of scenario made by a human error.
Should an employee be able to sign in if he returned to work on the week-end after having validated his timesheet on the friday? More likely, in any case he should ask a manager to reopen his timesheet? I think the timesheet in "Waiting approval" state shouldn't be alterable by the employee.
It also causes some other issues, with such timesheet, let's say the employee sent his timesheet to approval and then added a sign in.
The manager will be able to validate the timesheet as it is. He will have no warning when clicking on "Approve"
Furthermore, when the manager has validated (let's say he did it early as it is a short week in the end of month) the timesheet, the employee will still be able to sign in and sign out on that timesheet!
Related branches
- Martin Trigaux (OpenERP) (community): Disapprove
- Naresh(OpenERP) (community): Needs Fixing
- Yannick Vaucher @ Camptocamp (community): Needs Fixing
-
Diff: 35 lines (+18/-0)1 file modifiedhr_timesheet_sheet/hr_timesheet_sheet.py (+18/-0)
- OpenERP Core Team: Pending requested
-
Diff: 72 lines (+22/-19)1 file modifiedhr_timesheet_sheet/hr_timesheet_sheet.py (+22/-19)
| summary: |
- hr_timesheet_sheet - attendancies can be added on waiting approval and + hr_timesheet_sheet - attendances can be added on waiting approval and approved timesheets |
| summary: |
- hr_timesheet_sheet - attendances can be added on waiting approval and - approved timesheets + [7.0] hr_timesheet_sheet - attendances can be added on waiting approval + and approved timesheets |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP Publisher's Warranty Team (openerp-opw) |
| tags: | added: maintenance |
| Changed in openobject-addons: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| Martin Trigaux (OpenERP) (mat-openerp) wrote | #1 |
| Changed in openobject-addons: | |
| status: | Fix Committed → Fix Released |
Hello,
A fix was merged in 7.0, thanks for the report
revno: 10015 [merge]
revision-id: <email address hidden>