Rebuild doesn't have ImageNotActive check

Bug #1180604 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Rick Harris

Bug Description

We have a check on create to test whether the image's status is not 'active'.

I just noticed that we don't have this same check on rebuild.

The plan is to add that check plus tests with this fix, which could be backportable.

Then as a secondary patch, the plan is to refactor the image-checks into a common function that could be shared by create and rebuild.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29329

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/29329
Committed: http://github.com/openstack/nova/commit/4814a146712b21fa30236cef5f7d741c6ce337b6
Submitter: Jenkins
Branch: master

commit 4814a146712b21fa30236cef5f7d741c6ce337b6
Author: Rick Harris <email address hidden>
Date: Thu May 16 00:18:12 2013 +0000

    Add ImageNotActive check for instance rebuild

    We have a check in place on create to test whether the image is marked
    as deleted in Glance that doesn't exist on the rebuild method. This
    patch adds that check and tests, with a follow-on patch forthcoming to
    refactor the code to a shared method.

    Fixes bug 1180604

    Change-Id: I1e75313a72d2197e83f7dacf6bcbd6750dd490cd

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.