OpenStack Compute (nova)

Size handling in `_get_and_check_image_metadata`

Bug #1180159 reported by Rick Harris on 2013-05-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Rick Harris	OpenStack Compute (nova) 2013.2 "havana"

Bug Description

The function in question pulls `size` from image metadata, but doesn't cast it to an integer before comparison.

This should probably be backported to Grizzly as well.

Rick Harris (rconradharris) on 2013-05-15

Changed in nova:
assignee:	nobody → Rick Harris (rconradharris)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-05-15: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29181

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-05-17: Fix merged to nova (master)

Reviewed: https://review.openstack.org/29181
Committed: http://github.com/openstack/nova/commit/7f1670e9fbeb086913c89b07a1bc02854319e412
Submitter: Jenkins
Branch: master

commit 7f1670e9fbeb086913c89b07a1bc02854319e412
Author: Rick Harris <email address hidden>
Date: Wed May 15 01:41:16 2013 +0000

Cast `size` to int before comparison

    `_get_and_check_image_metadata` pulls `size` from the image, which
    comes in as string, but fails to convert it to an integer before
    comparing with the flavor's `root_gb` size. This patch adds the cast
    along with some test coverage for this method.

Fixes bug 1180159

Change-Id: I92bc9d6a808e49173d806e434cb145c751c8314a