Don't add the script directory to sys.path while running a test script
Bug #1179797 reported by
Vincent Ladeuil
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| selenium-simple-test |
Fix Released
|
High
|
Vincent Ladeuil | ||
Bug Description
From https:/
> 332 + # TODO: Adding script_dir to sys.path only makes sense if we want to
> 333 + # allow scripts to import from their own dir. Do we really need that
> ?
>
> To answer the question, I'd say no. We are trying to use the full path
> everywhere, so this only allows a behavior we are trying to avoid. If we
> remove it, it might break some tests, but that's fine as they should be
> updated anyway.
Related branches
lp:~vila/selenium-simple-test/test-loader
- Corey Goldberg (community): Approve
- Leo Arias (community): Approve (code review)
-
Diff: 1483 lines (+470/-754)9 files modifiedsrc/sst/filters.py (+3/-3)
src/sst/loader.py (+131/-286)
src/sst/result.py (+0/-3)
src/sst/runtests.py (+10/-17)
src/sst/selftests/shared/__init__.py (+3/-0)
src/sst/tests/test_filters.py (+1/-2)
src/sst/tests/test_loader.py (+272/-413)
src/sst/tests/test_runtests.py (+50/-1)
test-loader.TODO (+0/-29)
| Changed in selenium-simple-test: | |
| status: | Confirmed → In Progress |
| status: | In Progress → Fix Committed |
| Changed in selenium-simple-test: | |
| milestone: | none → 0.2.4 |
| Changed in selenium-simple-test: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
