log.py imports notifier which has tons of dependencies

Bug #1179528 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
Davanum Srinivas (DIMS)

Bug Description

Oslo.log imports notfier which has tons of dependencies. Since it is used just for PublishErrorsHandler which is used when `publish_errors` is set, I think it would be better to have it optional and / or move it to a separate module.

# marconi/openstack/common/context.py
# marconi/openstack/common/eventlet_backdoor.py
# marconi/openstack/common/excutils.py
# marconi/openstack/common/gettextutils.py
# marconi/openstack/common/jsonutils.py
# marconi/openstack/common/local.py
# marconi/openstack/common/log.py
# marconi/openstack/common/loopingcall.py
# marconi/openstack/common/network_utils.py
# marconi/openstack/common/notifier/
# marconi/openstack/common/processutils.py
# marconi/openstack/common/rpc/
# marconi/openstack/common/service.py
# marconi/openstack/common/threadgroup.py
# marconi/openstack/common/uuidutils.py

Revision history for this message
Mark McLoughlin (markmc) wrote :

Agree, we need to fix this. We just hit this here too: https://review.openstack.org/28868

Changed in oslo:
importance: Undecided → High
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29081

Changed in oslo:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/29081
Committed: http://github.com/openstack/oslo-incubator/commit/b135234079d0b01791f71568d4515ee828a96686
Submitter: Jenkins
Branch: master

commit b135234079d0b01791f71568d4515ee828a96686
Author: Davanum Srinivas <email address hidden>
Date: Tue May 14 08:39:36 2013 -0400

    Remove the notifier and its dependencies from log.py

    Move the code related to the publish error handler out of the
    log module so its easier for other projects to consume it

    Fixes LP #1179528

    Change-Id: Ibf28ba17f81b5ddeda653f6a3501ecac18ffcd42

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.