Bookmark folder tree collapsed on bookmarks update
Bug #1179200 reported by
André Auzi
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Midori Web Browser |
Fix Released
|
Medium
|
André Auzi | ||
Bug Description
When I edit bookmarks, either from the bookmark panel of the the bookmark bar the tree view of the bookmark panel is collapsed.
This is a major annoyance for user who like me have bookmarks classed in a deep tree.
I would expect the view remaining as it is with the appropriate update according the bookmark operation done eg. change, addition or deletion of the bookmark item or folder if it is in a visible part of the tree view.
Related branches
lp:~aauzi/midori/fix-1179200-8
- Cris Dywan: Approve
-
Diff: 373 lines (+262/-27)2 files modifiedpanels/midori-bookmarks.c (+262/-23)
panels/midori-bookmarks.h (+0/-4)
Revision history for this message
| André Auzi (aauzi) wrote | #1 |
Revision history for this message
| André Auzi (aauzi) wrote | #2 |
| Changed in midori: | |
| milestone: | none → 0.5.1 |
| Changed in midori: | |
| assignee: | nobody → André Auzi (aauzi) |
| milestone: | 0.5.3 → 0.5.4 |
| Changed in midori: | |
| milestone: | 0.5.4-freeze → 0.5.5 |
| Changed in midori: | |
| milestone: | 0.5.5-freeze → 0.5.6 |
| Changed in midori: | |
| status: | New → Confirmed |
| status: | Confirmed → Fix Committed |
| Changed in midori: | |
| status: | Fix Committed → Fix Released |
| Changed in midori: | |
| status: | Fix Released → In Progress |
| milestone: | 0.5.6 → 0.5.8 |
| importance: | Undecided → Medium |
| Changed in midori: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Kestutis Snieska (kestutis-snieska) wrote | #3 |
| Changed in midori: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The attached patch improves the situation.
The problem was apparently due to the handle, in the bookmarks panel of the katze array UPDATE signal.
This signal is widely used an, in the case of bookmarks, generates a refresh of the whole tree view from the database.
The proposed patch does not change this behaviour, used by bookmark imports, but reduces its unexpected effects.
It implements tree store manipulations based on the already exiting ADD_ITEM and REMOVE_ITEM plus an additional one created for the circumstance: UPDATE_ITEM.
It is worth to mention that this patch implements the GtkTreeDragDest
So far, with the patch the annoyance is less probable and the bookmarks panel more usable ;)