Remove all calls to the old ChildLogger class

Bug #1179000 reported by Marco Giusti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Virtualbricks
Fix Released
Low
Marco Giusti

Bug Description

Here a possibly inexact list of calls to ChildLogger's methods:

egrep -I -r '(debug|info|warning|error|err|exception)' virtualbricks/ | grep -v log\\.

 virtualmachines.py: self.debug( "CALLED hostonly connected" )
 virtualmachines.py: self.VM.factory.debug("Machine "+self.VM.name+" acquired master lock on image " + self.image.name)
 virtualmachines.py: self.VM.factory.debug("Machine "+self.VM.name+" acquired master lock on image " + self.image.name)
 virtualmachines.py: self.VM.factory.debug("%s private cow found with a different base image (%s): moving it in %s" % (cowname, base, cowback))
 virtualmachines.py: self.VM.factory.debug("Creating a new private COW from %s base image." % self.get_base())
 virtualmachines.py: self.factory.debug(_("Machine ")+self.name+_(" acquired master lock on image ")+disk.image.name)
 virtualmachines.py: self.factory.err(self, "No console detected.")
 virtualmachines.py: self.factory.err(self, "Virtual Machine startup failed. Check your configuration!\nMessage:\n"+"\n".join(self.proc.stdout.readlines()))
 virtualmachines.py: self.factory.err(self, "Virtual Machine startup failed. Check your configuration!\nMessage:\n"+"\n".join(stdout.readlines()))
 virtualmachines.py: self.factory.err(self, "Virtual Machine startup failed. Check your configuration!")
 bricks.py: self.debug(_("Starting: '%s'"), ' '.join(command_line))
 bricks.py: self.factory.err(self, _("Error: You must be connected to the "
 bricks.py: self.factory.err(self, _("OSError: Brick startup failed. Check"
 bricks.py: self.factory.err(self, _("Brick startup failed. Check your"
 bricks.py: self.factory.err(self, _("Brick startup failed. Check your"
 bricks.py: self.debug(_("Shutting down %s"), self.name)
 bricks.py: self.factory.err(self, _("can not stop brick error code:"),
 bricks.py: self.warning("Warning. The Event '" + self.cfg.poff_vbevent +
 bricks.py: self.debug("open_console")
 bricks.py: self.factory.err(self, _("Error: cannot start a terminal"
 bricks.py: self.exception(_("Error running command line") +
 bricks.py: self.debug("open_internal_console")
 bricks.py: self.debug(self.get_type() + " " + _("does not have a console"))
 bricks.py: self.factory.err(self, self.get_type() + ": " +
 bricks.py: self.debug(self.get_type() + ": cancel send")
 bricks.py: self.debug(self.get_type() + ": sending '%s'", msg)
 bricks.py: self.exception(self.get_type() + ": send failed : %s", err)
 bricks.py: self.debug("recv")
 switches.py: self.debug(self.name + ": callback 'fstp' with argument " + arg)
 switches.py: self.debug(self.recv())
 switches.py: self.debug(self.name + ": callback 'hub' with argument " + arg)
 switches.py: self.debug(self.recv())
 switches.py: self.debug(self.name + ": callback 'numports' with argument " +
 switches.py: self.debug(self.recv())
 wires.py:# self.debug( "CALLED PyWire connected" )
 wires.py: self.debug(self.name + ": callback 'bandwidth LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'bandwidth RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'bandwidth RL&LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'speed LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'speed RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'speed LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'delay LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'delay RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'delay LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'chanbufsize (capacity) LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'chanbufsize (capacity) RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'chanbufsize (capacity) LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'loss LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'loss RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'loss LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'dup LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'dup RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'dup RL&LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'noise LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'noise RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'noise LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'lostburst LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'lostburst RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'lostburst RL&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'mtu LR' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'mtu RL' with argument " + value)
 wires.py: self.debug(self.recv())
 wires.py: self.debug(self.name + ": callback 'mtu LR&RL' with argument " + value)
 wires.py: self.debug(self.recv())
 events.py: self.info(_("Added vb-shell command: '%s'"), unicode(action))
 events.py: self.info(_("Added host-shell command: '%s'"), unicode(action))
 events.py: self.factory.err(self, "Error: cannot execute shell "
 configfile.py: self.factory.factory.err(self.factory,
 configfile.py: self.factory.debug("************************* sock detected")
 configfile.py: self.factory.debug("added eth%d" % pl.vlan)
 configfile.py: self.factory.debug("************************* link detected")
 configfile.py: self.factory.warning("socket '" + sockname +
 configfile.py: self.factory.debug("added eth%d" % pl.vlan)
 configfile.py: self.factory.info("new %s : %s", ntype, name)
 configfile.py: self.factory.debug("Found Disk image %s" % name)
 configfile.py: self.factory.debug("Found remote host %s" % name)
 configfile.py: self.factory.exception("--------- Bad config line:" +
 brickfactory.py: self.info(_('Engine: Bye!'))
 brickfactory.py: self.error(*args, **kwds)
 brickfactory.py: self.debug("Endpoint %s not found." % nick)
 brickfactory.py: self.debug("Name error duplicating event.")
 brickfactory.py: self.debug("Deleting plug to " + pl.sock.nickname)
 gui/gui.py: gui.debug("proc list updated")
 gui/gui.py: self.info("Starting VirtualBricks!")
 gui/gui.py: self.error(missing_text + "\nThere are some components not found: " + missing_components + " some functionalities may not be available.\nYou can disable this alert from the general settings.")
 gui/gui.py: self.debug("event config")
 gui/gui.py: self.debug("switch config")
 gui/gui.py: self.debug("qemu config")
 gui/gui.py: self.debug("tap config")
 gui/gui.py: self.debug("wire config")
 gui/gui.py: self.debug("wirefilter config")
 gui/gui.py: self.debug("tunnelc config")
 gui/gui.py: self.debug("tunnell config")
 gui/gui.py: self.debug("capture config")
 gui/gui.py: self.debug("switchwrapper config")
 gui/gui.py: self.debug("router config")
 gui/gui.py: self.debug("Error: invalid brick type")
 gui/gui.py: self.error(_("Cannot create brick: Invalid name."))
 gui/gui.py: self.debug("Created successfully")
 gui/gui.py: self.error(_("Cannot create brick: Invalid name."))
 gui/gui.py: self.debug("Created successfully")
 gui/gui.py: self.error(_("The name \"")+eventname+_("\" has forbidden format."))
 gui/gui.py: self.error(_("The name \"")+eventname+_("\" has been adapted to \"")+validname+"\".")
 gui/gui.py: self.error(_("An object named \"")+eventname+_("\" already exist."))
 gui/gui.py: self.error(_("Cannot create event: Invalid name."))
 gui/gui.py: self.debug('dropped before')
 gui/gui.py: self.debug('dropped after')
 gui/gui.py: self.debug("drag&drop: %s onto %s", self.Dragging.name, dropbrick.name)
 gui/gui.py: self.debug( "Power OFF" )
 gui/gui.py: self.debug ( "Power ON" )
 gui/gui.py: self.error(_("Cannot start '%s': not configured"),
 gui/gui.py: self.error(_("Cannot start '%s': not connected"),
 gui/gui.py: self.error(_("Loop link detected: aborting operation. If you want to start "
 gui/gui.py: self.error(_("Disk used by the VM is locked:\n")+str(ex))
 gui/gui.py: self.error("Error connecting to remote host %s: %s" % (self.remotehost_selected.addr[0], msg))
 gui/gui.py: self.debug("Apply settings...")
 gui/gui.py: self.error("Invalid name")
 gui/gui.py: self.error("Name already in use")
 gui/gui.py: self.debug("Image creating.. ",)
 gui/gui.py: self.error(_("Choose a filename first!"))
 gui/gui.py: self.debug("Sending to process signal 19!")
 gui/gui.py: self.debug("Sending to process signal 18!")
 gui/gui.py: self.debug(self.joblist_selected)
 gui/gui.py: self.debug("Restarting process!")
 gui/gui.py: self.debug("Sending to process signal 9!")
 gui/gui.py: self.error(_("Cannot rename Brick: it is in use."))
 gui/gui.py: self.error(_("Invalid name!"))
 gui/gui.py: self.error(_("Cannot rename Event: it is in use."))
 gui/gui.py: self.error(_("Invalid name!"))
 gui/gui.py: self.debug("Event created successfully")
 gui/gui.py: self.error(_("Invalid name!"))
 gui/gui.py: self.debug("Event created successfully")
 gui/gui.py: self.error(_("No KVM support found on the system. "
 gui/gui.py: self.error(_("Suspend/Resume not supported on this disk."))
 gui/gui.py: self.debug("resume")
 gui/gui.py: self.error(_("Cannot find suspend point."))
 gui/gui.py: self.error(_("Error saving topology: Invalid image format"))
 gui/gui.py: self.error(_("Error saving topology: Could not write file"))
 gui/gui.py: self.error(_("Error saving topology: Unknown error"))
 gui/gui.py: self.error("Error connecting to remote host %s: %s" % (self.remotehost_selected.addr[0], msg))
 gui/gui.py: self.error('Unable to read image')
 gui/gui.py: self.error('Failed to commit image')
 gui/gui.py: self.error("Invalid image")
 gui/gui.py: self.error("Error: "+path+" is not a valid COW image")
 gui/gui.py: self.error("Select a file")
 gui/gui.py: self.error("Cannot write to the specified location")
 tcpserver.py: self.info("%s: Client authenticated.", str(addr))
 tcpserver.py: self.info("%s: Authentication failed. " % str(addr))
 tcpserver.py: self.info("%s: Challenge timeout", str(addr))

 affects virtualbrick
 assignee marco-giusti
 importance low
 milestone 1.0

Related branches

Revision history for this message
Marco Giusti (marco-giusti) wrote :

This bug is almost fixed with the exception of wires.py

$ egrep -I -r -l '(factory|self)\.(debug|info|warning|err(or)?|exception)' virtualbricks/
virtualbricks/wires.py
$

Revision history for this message
Marco Giusti (marco-giusti) wrote :

This is fixed but the commit was lost in time.

Changed in virtualbrick:
status: New → Fix Committed
Changed in virtualbrick:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.