move s3_token middleware to keystoneclient

Bug #1178741 reported by Adam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Brant Knudson
python-keystoneclient
Fix Released
Wishlist
Brant Knudson

Bug Description

s3_token middleware is in keystone, and needs to be moved to the keystoneclient project just like we moved the auth_token middleware.

Dolph Mathews (dolph)
Changed in keystone:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Nachiappan (nachiappan) wrote :

The following proposal will address the issue mentioned in the bug.

https://blueprints.launchpad.net/keystone/+spec/generic-signature-validation

Dolph Mathews (dolph)
Changed in keystone:
importance: Medium → Wishlist
Revision history for this message
Dolph Mathews (dolph) wrote :

Reduced the scope of this to just s3_token

summary: - move remaining middleware to keystone client
+ move s3_token middleware to keystoneclient
description: updated
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Wishlist
Changed in python-keystoneclient:
assignee: nobody → Brant Knudson (blk-u)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/52702
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=d7ef819a319828bfaa37bb7f083e6ad3062fb6d2
Submitter: Jenkins
Branch: master

commit d7ef819a319828bfaa37bb7f083e6ad3062fb6d2
Author: Brant Knudson <email address hidden>
Date: Fri Oct 18 15:31:20 2013 -0500

    Copy s3_token middleware from keystone

    The s3_token middleware was in keystone but it should be in
    python-keystoneclient. As a first step to removing s3_token from
    keystone, copy it to python-keystoneclient. Also copy the tests.

    A couple of changes were required

    - Changed oslo-incubator imports from keystone to keystoneclient.
    - Changed logging from oslo-incubator to use Python logging and
      configured the same way as the auth_token middleware.

    I checked and I didn't see anything to be added to requirements.txt
    or test-requirements.txt.

    bp s3-token-to-keystoneclient

    Change-Id: I64fef4101180e5aa661442d538c3237bdad0c37c
    Closes-Bug: #1178741

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
Brant Knudson (blk-u) wrote :

Since this is committed to python-keystoneclient, when there's a new release I can update keystone to import and deprecate.

Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.5.0
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Brant Knudson (blk-u)
Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/70240
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7599d9655371e65d063d290f871dc2e5002d9b29
Submitter: Jenkins
Branch: master

commit 7599d9655371e65d063d290f871dc2e5002d9b29
Author: Brant Knudson <email address hidden>
Date: Thu Jan 30 16:53:00 2014 -0600

    Update requirements to 661e6

    The requirements are updated to requirements project commit
    661e6bad9e56dddd65a200dc08aedc00b9656312

     $ cd /opt/stack/requirements
     $ python update.py ../keystone

    bp s3-token-to-keystoneclient

    Closes-Bug: #1270909
    Closes-Bug: #1277583
    Related-Bug: #1178741
    Change-Id: If7ddef69076e1b03c5efbf4f05bb349bbecfa015

Revision history for this message
Brant Knudson (blk-u) wrote :

The code to have keystone use keystoneclient's s3_token middleware was merged in 81b3136fb635da54ce1f880faee95d85cddda3fd .

Changed in keystone:
status: Confirmed → Fix Committed
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.