poll_rebooting_instances hits DB directly in Xen/VMware virt drivers

Bug #1177993 reported by Hans Lindgren
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
melanie witt

Bug Description

To hard-reboot any stuck-in-reboot instances, both drivers call compute_api.reboot() on the instances which in turn updates the instance state via calls to self.update() -> self._update() -> self.db.instance_update_and_get_original().

Hans Lindgren (hanlind)
tags: added: grizzly-backport-potential
melanie witt (melwitt)
Changed in nova:
status: New → Confirmed
melanie witt (melwitt)
Changed in nova:
assignee: nobody → Melanie Witt (melwitt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29453

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Shawn Hartsock (hartsock) wrote :

This looks like it's just waiting on a core reviewer.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/29453
Committed: http://github.com/openstack/nova/commit/1d4daa8f6179945508767019eaa078e22b1636f6
Submitter: Jenkins
Branch: master

commit 1d4daa8f6179945508767019eaa078e22b1636f6
Author: Melanie Witt <email address hidden>
Date: Thu May 16 22:51:48 2013 +0000

    update xen/vmware virt drivers not to hit db directly

    This change replaces calls to compute api with calls to
    conductor api updated with a 'compute_reboot' function.

    Fix for bug 1177993

    Change-Id: I9aefba95cce29c1486fdfb25008f8da9ece1c19b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/39036

Revision history for this message
Gary Kotton (garyk) wrote :

Removed the grizzly backport potential. The concensus was that it was not a critical issue that should be backported

tags: removed: grizzly-backport-potential
Tracy Jones (tjones-i)
tags: added: vmware-co-preferred
tags: removed: vmware-co-preferred
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
status: New → Fix Released
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
importance: Undecided → High
Changed in openstack-vmwareapi-team:
importance: High → Low
no longer affects: openstack-vmwareapi-team
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.