signon-ui in ubuntu-touch should use Ubuntu.Browser plugin
Bug #1177964 reported by
Bill Filler
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Online Accounts: Sign-on UI |
In Progress
|
Medium
|
Alberto Mardegan |
Bug Description
It appears the browser component used by the webbrowser-app in ubuntu-touch is created as a qml plugin. Signon-ui should use this plugin for it's webview as there are many issues that would go away if we do and it would be consistent with the functionality of the built-in browser.
Specifically, the following things would work better:
- correct user-agent string set
- support for device rotation
- setting of proper dpr (currently the webview in signon-ui is not setting this correctly and the view is too small)
- proper sizing of window.
Related branches
lp:~mardy/signon-ui/oxide
- Justin McPherson: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Online Accounts: Pending requested
-
Diff: 1534 lines (+322/-926)24 files modified.bzrignore (+1/-0)
debian/changelog (+6/-0)
debian/rules (+1/-1)
src/browser-process/UserAgent.qml (+0/-90)
src/browser-process/WebView.qml (+0/-62)
src/browser-process/browser-process.cpp (+0/-291)
src/browser-process/browser-process.h (+0/-50)
src/browser-process/browser-process.pro (+0/-64)
src/browser-process/debug.h (+0/-37)
src/browser-process/main.cpp (+0/-68)
src/browser-process/signon-ui-browser-process.desktop.in (+0/-11)
src/browser-process/ua-overrides.js (+0/-99)
src/com.nokia.singlesignonui.service.in (+1/-1)
src/qml/MainWindow.qml (+1/-0)
src/qml/WebView.qml (+24/-0)
src/qml/qml.qrc (+0/-2)
src/qquick-dialog.cpp (+2/-2)
src/qquick-dialog.h (+8/-4)
src/request.cpp (+6/-6)
src/signon-ui.desktop.in (+11/-0)
src/signon-ui.pro (+24/-7)
src/src.pro (+0/-7)
src/ubuntu-browser-request.cpp (+224/-110)
src/ubuntu-browser-request.h (+13/-14)
Changed in signon-ui: | |
assignee: | nobody → Ken VanDine (ken-vandine) |
status: | New → Triaged |
importance: | Undecided → Medium |
To post a comment you must log in.
Confirmed the browser component is available as a plugin, you need to import:
import Ubuntu.Browser 0.1
And various other components are available as well, like Chrome and AddressBar