Cannot activate PO which contains only direct charges (no bibs)

[Bill Erickson]

Confirmed in Evergreen master circa 2.4; likely affects 2.3, possibly 2.2

Create a PO and add a direct charge under the "Direct Charges, Taxes, Fees, etc." section along the bottom of the PO interface. Attempting to activate the PO (to encumber the funds) hangs on the PO activation status page as a result of this error:

Error: Error: Method error: undefined : *** Call to [open-ils.acq.purchase_order.assets.create] failed for session [0.85616683602846611368037983218], thread trace [10]:
Can't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.14.2/OpenILS/Application/Acq/Order.pm line 532.

It would appear that some aspect(s) of the code assume a PO contains at least one bib w/ copies, however it should be possible to activate a PO with only direct charges.

[Steven Chan (schan2)]

Sitka identified this bug back in July 2012 on version 2.2 and applied a fix, but we forgot to report a launchpad ticket. Here is a patch of our fix.

[Jennifer Pringle (jpringle-u)]

Steven's fix is used on our live 2.2 system and also on our 2.4.0 test server.

[Jason Stephenson (jstephenson)]

Steven,

Do you have a ssh key on the git.evergreen-ils.org server?

If you do, it would be helpful if you could make a branch in the working repository for this patch.

If not, it would still be helpful for you to have a key on the server so that you can make a branch in the working repository for this patch.

For more information, see:

http://www.open-ils.org/dokuwiki/doku.php?id=dev:git

Jason S.

[Jason Stephenson (jstephenson)]

I have made a branch in the working repository with Steven's patch applied:

working/collab/dyrcona/lp1177916

[Kathy Lussier (klussier)]

This works for me. I added a sign off at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1177916.

Kathy

[Jason Stephenson (jstephenson)]

Thanks, Steven and Kathy.

Committed to master, 2.4, and 2.3.