Dynamic pointer in two needle load meter not working

Bug #1177436 reported by Mervyn Burse
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Medium
cjakeman

Bug Description

There are a number of MSTS cvf files that use two or more pointers to display ammeter information. Currently, none of those I have tested work properly in one way or another. The two pointer dial type ammeter has one pointer for "traction" which works properly but the "dynamic" indicator does not move although from the HUD it is clear that dynamic brakes do in fact work.

I have included one example of each type I have found so far.

There is also a problem with another type of display that uses pointers moving in a vertical scale of which the default series 2000 electric is an example. In this one the pointer should run bottom to top, but moves in the opposite direction.

Tags: cabs
Revision history for this message
Mervyn Burse (mervyn) wrote :
Peter Gulyas (pzgulyas)
tags: added: cabs
cjakeman (cjakeman)
Changed in or:
assignee: nobody → cjakeman (cjakeman)
milestone: none → 0.9
importance: Undecided → Medium
cjakeman (cjakeman)
Changed in or:
status: New → In Progress
cjakeman (cjakeman)
Changed in or:
milestone: 0.9 → 1.0
Revision history for this message
Carlo Santucci (carlosanit1) wrote :

Where can the complete cab pack be downloaded?

Revision history for this message
Mervyn Burse (mervyn) wrote : Re: [Bug 1177436] Re: Dynamic pointer in two needle load meter not working

trainsim.com http://www.trainsim.com/vbts/tslib.php?do=copyright&fid=26553
is a set by Charlie Sibaja. That gets you the type that moves across the top
sector of the dial

http://www.trainsim.com/vbts/tslib.php?do=copyright&fid=19239 by Dwight
Mitchell. That one uses the bottom sector of the dial. In both cases the two
needles should move left to right.

For the vertical type of movement the default 2000 should be ok.

Mervyn

-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2012.0.2242 / Virus Database: 3204/5969 - Release Date: 07/06/13

Revision history for this message
Carlo Santucci (carlosanit1) wrote :

I believe I have found the bug, and attach here my proposed patch. At least the GenGP9 cab pointer moves with this patch. I wonder if the same correction should be inserted also for the tractive force load meter, even if usually it would not have effect, as the minimum value for that one is 0.

Revision history for this message
Mervyn Burse (mervyn) wrote :

As the tractive force needle is working properly at the moment, I would be inclined to leave that alone.

Revision history for this message
Carlo Santucci (carlosanit1) wrote :

I attach here a reviewed patch, that intervenes only when the maximum range value of the cabview meter is equal to 0, leaving things unaltered in the other cases.

Revision history for this message
cjakeman (cjakeman) wrote :

Hi Carlo,

Am home once more (great weekend), so hope to commit your patch this evening.

Which loco cabs are you testing these changes with?

Chris

Revision history for this message
cjakeman (cjakeman) wrote :

Hi Carlo,

Commit your patch as planned.

Which loco cabs are you testing these changes with?

Chris

Revision history for this message
Carlo Santucci (carlosanit1) wrote :

I have tested it with the GenGP9 cab (one of them mentioned by Mervyn) and with the standard D9 cab, to check that existing cabs still work.

Revision history for this message
Peter Gulyas (pzgulyas) wrote :

Fixed in X1685.

Changed in or:
status: In Progress → Fix Committed
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.