When pasting image should not get finalized (regression)

[grofaty]

Pinta latest development on Ubuntu 12.04 it looks like bug 689224 from Pinta 0.5 has reappeared. I decided to open a new bug and not comment on ancient bug, because it may be a different problem.

This is regression and it makes Pinta almost unusable for my day to day work.

P.S. Please mark this bug as High importance.

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

This sounds a lot like a regression I introduced with https://github.com/PintaProject/Pinta/pull/56 I was not aware of the previous bug you mentioned. I will need to figure out a way to refresh the layer preview without Finalizing the image during the Paste operation.

[Cameron White (cameronwhite91)]

I'm thinking we might want to have the layer list widget's preview display the selection layer on top of the active layer, instead of doing special stuff for the paste operation. For example, if you select some area of an image and use the Move Selected Pixels tool to move it somewhere else, any subsequent moves will not update the layer preview until a Finish Pixels action occurs.

[grofaty (grofaty)]

I tested the paste and not finalizing operation in:
- Paint.NET,
- Microsoft Paint and
- Gimp.
All of above tools are working pasting and not finalizing it automatically, just like Pinta was before regression.

[grofaty (grofaty)]

On Ubuntu 12.04 I have git checkout the commits one by one and see the problem first appears at commit 9e3f8f5a8547bfb8218b64c71a36a46636cf4888 with name "Refresh layer preview after paste image action without adding extra history items" on May 4, 2013.

[grofaty (grofaty)]

Tested pinta-1.5-preview-20130518 on Windows XP and this problem still appears. This is major problem in my day to day work with images using Pinta.

Just a note, importance of this bug is still set as "Undecided".

[Elvis Alistar (ealis2001-deactivatedaccount-deactivatedaccount)]

I was a bit busy lately with my regular job, but I will try to get working on this ASAP. In the meantime, Cameron or others, feel free to take a look at it if you think it can't wait a bit more.

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/commit/d628f2ef47f037935479d33d7c33dadd35f47b39

[grofaty (grofaty)]

Tested on master on Windows XP and problem is fixed. This was very annoying bug using Pinta development... excellent to be fixed. Thanks.